Explorar el Código

Proper naming of property with const read method

Andreas Fetzer hace 11 años
padre
commit
386d7ad6f7

+ 3 - 0
Libs/DICOM/Widgets/Resources/UI/ctkDICOMBrowser.ui

@@ -113,6 +113,9 @@
      </property>
      <item>
       <widget class="ctkDICOMTableManager" name="dicomTableManager">
+       <property name="dynamicTableLayout">
+        <bool>true</bool>
+       </property>
        <property name="m_DynamicLayout" stdset="0">
         <bool>true</bool>
        </property>

+ 7 - 7
Libs/DICOM/Widgets/ctkDICOMTableManager.cpp

@@ -45,14 +45,14 @@ public:
 
   ctkDICOMDatabase* dicomDatabase;
 
-  bool m_DynamicLayout;
+  bool m_DynamicTableLayout;
 };
 
 //------------------------------------------------------------------------------
 
 ctkDICOMTableManagerPrivate::ctkDICOMTableManagerPrivate(ctkDICOMTableManager &obj)
   : q_ptr(&obj)
-  , m_DynamicLayout(false)
+  , m_DynamicTableLayout(false)
 {
 
 }
@@ -236,20 +236,20 @@ void ctkDICOMTableManager::onStudiesSelectionChanged(const QStringList &uids)
 void ctkDICOMTableManager::setDynamicTableLayout(bool dynamic)
 {
   Q_D(ctkDICOMTableManager);
-  d->m_DynamicLayout = dynamic;
+  d->m_DynamicTableLayout = dynamic;
 }
 
-bool ctkDICOMTableManager::dynamicTableLayout()
+bool ctkDICOMTableManager::dynamicTableLayout() const
 {
-  Q_D(ctkDICOMTableManager);
-  return d->m_DynamicLayout;
+  Q_D(const ctkDICOMTableManager);
+  return d->m_DynamicTableLayout;
 }
 
 void ctkDICOMTableManager::resizeEvent(QResizeEvent *e)
 {
   this->Superclass::resizeEvent(e);
   Q_D(ctkDICOMTableManager);
-  if (!d->m_DynamicLayout)
+  if (!d->m_DynamicTableLayout)
     return;
 
   //Minimum size = 800 * 1.28 = 1024 => use horizontal layout (otherwise table size would be too small)

+ 2 - 2
Libs/DICOM/Widgets/ctkDICOMTableManager.h

@@ -48,7 +48,7 @@ class CTK_DICOM_WIDGETS_EXPORT ctkDICOMTableManager : public QWidget
     * Property for setting a dynamic table layout which switches according to the current
     * window size between vertical and horizontal layout
     */
-  Q_PROPERTY(bool m_DynamicLayout READ dynamicTableLayout WRITE setDynamicTableLayout)
+  Q_PROPERTY(bool dynamicTableLayout READ dynamicTableLayout WRITE setDynamicTableLayout)
 
 public:
   typedef QWidget Superclass;
@@ -75,7 +75,7 @@ public:
   QStringList currentSeriesSelection();
 
   void setDynamicTableLayout(bool);
-  bool dynamicTableLayout();
+  bool dynamicTableLayout() const;
 
 public Q_SLOTS: