소스 검색

Merge branch 'ctkcolordialogtest2-timeout'

* ctkcolordialogtest2-timeout:
  Remove ctkColorDialog warnings when not using nameSignal
  Fix ctkColorDialogTest2 time out
Julien Finet 12 년 전
부모
커밋
4f5bc9832e
2개의 변경된 파일5개의 추가작업 그리고 5개의 파일을 삭제
  1. 1 1
      Libs/Widgets/Testing/Cpp/ctkColorDialogTest2.cpp
  2. 4 4
      Libs/Widgets/ctkColorDialog.cpp

+ 1 - 1
Libs/Widgets/Testing/Cpp/ctkColorDialogTest2.cpp

@@ -53,5 +53,5 @@ int ctkColorDialogTest2(int argc, char * argv [] )
               << std::endl;
               << std::endl;
     return EXIT_FAILURE;
     return EXIT_FAILURE;
     }
     }
-  return app.exec();
+  return EXIT_SUCCESS;
 }
 }

+ 4 - 4
Libs/Widgets/ctkColorDialog.cpp

@@ -151,12 +151,12 @@ QColor ctkColorDialog::getColor(const QColor &initial, QWidget *parent, const QS
   foreach(QWidget* tab, ctkColorDialog::DefaultTabs)
   foreach(QWidget* tab, ctkColorDialog::DefaultTabs)
     {
     {
     dlg.insertTab(tab->property("tabIndex").toInt(), tab, tab->windowTitle());
     dlg.insertTab(tab->property("tabIndex").toInt(), tab, tab->windowTitle());
-    if (tab->property("colorSignal").isValid())
+    if (!tab->property("colorSignal").isNull())
       {
       {
       QObject::connect(tab, tab->property("colorSignal").toString().toLatin1(),
       QObject::connect(tab, tab->property("colorSignal").toString().toLatin1(),
                        &dlg, SLOT(setColor(QColor)));
                        &dlg, SLOT(setColor(QColor)));
       }
       }
-    if (tab->property("nameSignal").isValid())
+    if (!tab->property("nameSignal").isNull())
       {
       {
       QObject::connect(tab, tab->property("nameSignal").toString().toLatin1(),
       QObject::connect(tab, tab->property("nameSignal").toString().toLatin1(),
                        &dlg, SLOT(setColorName(QString)));
                        &dlg, SLOT(setColorName(QString)));
@@ -167,12 +167,12 @@ QColor ctkColorDialog::getColor(const QColor &initial, QWidget *parent, const QS
   foreach(QWidget* tab, ctkColorDialog::DefaultTabs)
   foreach(QWidget* tab, ctkColorDialog::DefaultTabs)
     {
     {
     dlg.removeTab(dlg.indexOf(tab));
     dlg.removeTab(dlg.indexOf(tab));
-    if (tab->property("colorSignal").isValid())
+    if (!tab->property("colorSignal").isNull())
       {
       {
       QObject::disconnect(tab, tab->property("colorSignal").toString().toLatin1(),
       QObject::disconnect(tab, tab->property("colorSignal").toString().toLatin1(),
                           &dlg, SLOT(setColor(QColor)));
                           &dlg, SLOT(setColor(QColor)));
       }
       }
-    if (tab->property("nameSignal").isValid())
+    if (!tab->property("nameSignal").isNull())
       {
       {
       QObject::disconnect(tab, tab->property("nameSignal").toString().toLatin1(),
       QObject::disconnect(tab, tab->property("nameSignal").toString().toLatin1(),
                           &dlg, SLOT(setColorName(QString)));
                           &dlg, SLOT(setColorName(QString)));