Sfoglia il codice sorgente

ctkDoubleRangeSlider was firing too many signals

ctkDoubleRangeSlider listens to ctkRangeSlider::valuesChanged() and it is
enough, that signal is fired even if just 1 value is modified.
By listening to other signals, it fires duplicate signals.
Julien Finet 14 anni fa
parent
commit
76a47c0b1e

+ 0 - 32
Libs/Widgets/ctkDoubleRangeSlider.cpp

@@ -100,10 +100,6 @@ void ctkDoubleRangeSliderPrivate::init()
 void ctkDoubleRangeSliderPrivate::connectSlider()
 {
   Q_Q(ctkDoubleRangeSlider);
-  q->connect(this->Slider, SIGNAL(minimumValueChanged(int)),
-             q, SLOT(onMinValueChanged(int)));
-  q->connect(this->Slider, SIGNAL(maximumValueChanged(int)),
-             q, SLOT(onMaxValueChanged(int)));
   q->connect(this->Slider, SIGNAL(valuesChanged(int,int)),
              q, SLOT(onValuesChanged(int,int)));
 
@@ -535,34 +531,6 @@ void ctkDoubleRangeSlider::setSymmetricMoves(bool symmetry)
 }
 
 // --------------------------------------------------------------------------
-void ctkDoubleRangeSlider::onMinValueChanged(int newValue)
-{
-  Q_D(ctkDoubleRangeSlider);
-  double doubleNewValue = d->minFromInt(newValue);
-  if (d->MinValue == doubleNewValue)
-    {
-    return;
-    }
-  d->MinValue = doubleNewValue;
-  emit this->valuesChanged(d->MinValue, d->MaxValue);
-  emit this->minimumValueChanged(d->MinValue);
-}
-
-// --------------------------------------------------------------------------
-void ctkDoubleRangeSlider::onMaxValueChanged(int newValue)
-{
-  Q_D(ctkDoubleRangeSlider);
-  double doubleNewValue = d->maxFromInt(newValue);
-  if (d->MaxValue == doubleNewValue)
-    {
-    return;
-    }
-  d->MaxValue = doubleNewValue;
-  emit this->valuesChanged(d->MinValue, d->MaxValue);
-  emit this->maximumValueChanged(d->MaxValue);
-}
-
-// --------------------------------------------------------------------------
 void ctkDoubleRangeSlider::onValuesChanged(int newMinValue, int newMaxValue)
 {
   Q_D(ctkDoubleRangeSlider);

+ 0 - 2
Libs/Widgets/ctkDoubleRangeSlider.h

@@ -231,8 +231,6 @@ public slots:
   void setValues(double minVal, double maxVal);
 
 protected slots:
-  void onMinValueChanged(int value);
-  void onMaxValueChanged(int value);
   void onValuesChanged(int min, int max);
 
   void onMinPosChanged(int value);