Procházet zdrojové kódy

Clean-up codes: warnings, namings, include file sortings

nherlambang před 14 roky
rodič
revize
8326254c92

+ 3 - 3
Libs/DICOM/Core/ctkDICOMFilterProxyModel.cpp

@@ -95,21 +95,21 @@ bool ctkDICOMFilterProxyModel::filterAcceptsRow(int source_row, const QModelInde
 
     if(model){
         QModelIndex index = model->index(source_row, 0, source_parent);
-        if(model->data(index, ctkDICOMModel::TypeRole) == ctkDICOMModel::PatientType){
+        if(model->data(index, ctkDICOMModel::TypeRole) == static_cast<int>(ctkDICOMModel::PatientType)){
             QRegExp regExp = QRegExp(d->searchTextName);
             if(model->data(index, Qt::DisplayRole).toString().contains(regExp)){
                 return true;
             }else{
                 return false;
             }
-        }else if(model->data(index, ctkDICOMModel::TypeRole) == ctkDICOMModel::StudyType){
+        }else if(model->data(index, ctkDICOMModel::TypeRole) == static_cast<int>(ctkDICOMModel::StudyType)){
             QRegExp regExp = QRegExp(d->searchTextStudy);
             if(model->data(index, Qt::DisplayRole).toString().contains(regExp)){
                 return true;
             }else{
                 return false;
             }
-        }else if(model->data(index, ctkDICOMModel::TypeRole) == ctkDICOMModel::SeriesType){
+        }else if(model->data(index, ctkDICOMModel::TypeRole) == static_cast<int>(ctkDICOMModel::SeriesType)){
             QRegExp regExp = QRegExp(d->searchTextSeries);
             if(model->data(index, Qt::DisplayRole).toString().contains(regExp)){
                 return true;

+ 1 - 1
Libs/DICOM/Core/ctkDICOMModel.h

@@ -22,7 +22,7 @@
 #define __ctkDICOMModel_h
 
 // Qt includes 
-#include <QStandardItemModel>
+#include <QAbstractItemModel>
 #include <QSqlDatabase>
 
 #include "ctkDICOMCoreExport.h"

+ 44 - 41
Libs/DICOM/Widgets/Resources/UI/ctkDICOMAppWidget.ui

@@ -21,25 +21,28 @@
   </property>
   <layout class="QVBoxLayout" name="verticalLayout_2">
    <item>
-    <widget class="QToolBar" name="toolBar">
+    <layout class="QHBoxLayout" name="HorizontalLayout_3"/>
+   </item>
+   <item>
+    <widget class="QToolBar" name="ToolBar">
      <property name="windowTitle">
       <string>toolBar</string>
      </property>
      <property name="floatable">
       <bool>true</bool>
      </property>
-     <addaction name="actionImport"/>
-     <addaction name="actionExport"/>
-     <addaction name="actionQuery"/>
-     <addaction name="actionSend"/>
+     <addaction name="ActionImport"/>
+     <addaction name="ActionExport"/>
+     <addaction name="ActionQuery"/>
+     <addaction name="ActionSend"/>
     </widget>
    </item>
    <item>
-    <layout class="QVBoxLayout" name="verticalLayout">
+    <layout class="QVBoxLayout" name="VerticalLayout">
      <item>
-      <layout class="QHBoxLayout" name="topLayout">
+      <layout class="QHBoxLayout" name="TopLayout">
        <item>
-        <widget class="QLabel" name="label">
+        <widget class="QLabel" name="DatabaseNameLabel">
          <property name="maximumSize">
           <size>
            <width>100</width>
@@ -52,7 +55,7 @@
         </widget>
        </item>
        <item>
-        <widget class="ctkDirectoryButton" name="directoryButton" native="true">
+        <widget class="ctkDirectoryButton" name="DirectoryButton" native="true">
          <property name="minimumSize">
           <size>
            <width>200</width>
@@ -62,7 +65,7 @@
         </widget>
        </item>
        <item>
-        <spacer name="horizontalSpacer">
+        <spacer name="HorizontalSpacer">
          <property name="orientation">
           <enum>Qt::Horizontal</enum>
          </property>
@@ -77,9 +80,9 @@
       </layout>
      </item>
      <item>
-      <layout class="QHBoxLayout" name="queryLayout" stretch="1,0">
+      <layout class="QHBoxLayout" name="QueryLayout" stretch="1,0">
        <item>
-        <widget class="QTreeView" name="treeView">
+        <widget class="QTreeView" name="TreeView">
          <property name="alternatingRowColors">
           <bool>true</bool>
          </property>
@@ -88,10 +91,10 @@
        <item>
         <layout class="QVBoxLayout" name="searchOptionLayout">
          <item>
-          <widget class="ctkDICOMQueryWidget" name="searchOption" native="true"/>
+          <widget class="ctkDICOMQueryWidget" name="SearchOption" native="true"/>
          </item>
          <item>
-          <spacer name="verticalSpacer">
+          <spacer name="VerticalSpacer">
            <property name="orientation">
             <enum>Qt::Vertical</enum>
            </property>
@@ -108,7 +111,7 @@
       </layout>
      </item>
      <item>
-      <widget class="QFrame" name="userFrame">
+      <widget class="QFrame" name="UserFrame">
        <property name="frameShape">
         <enum>QFrame::StyledPanel</enum>
        </property>
@@ -118,9 +121,9 @@
       </widget>
      </item>
      <item>
-      <layout class="QHBoxLayout" name="viewerLayout">
+      <layout class="QHBoxLayout" name="ViewerLayout">
        <item>
-        <widget class="ctkDICOMThumbnailListWidget" name="thumbnailsWidget" native="true">
+        <widget class="ctkDICOMThumbnailListWidget" name="ThumbnailsWidget" native="true">
          <property name="sizePolicy">
           <sizepolicy hsizetype="Expanding" vsizetype="Expanding">
            <horstretch>0</horstretch>
@@ -136,7 +139,7 @@
         </widget>
        </item>
        <item>
-        <widget class="QFrame" name="previewFrame">
+        <widget class="QFrame" name="PreviewFrame">
          <property name="minimumSize">
           <size>
            <width>256</width>
@@ -145,9 +148,9 @@
          </property>
          <layout class="QVBoxLayout" name="verticalLayout_3">
           <item>
-           <layout class="QHBoxLayout" name="horizontalLayout">
+           <layout class="QHBoxLayout" name="HorizontalLayout">
             <item>
-             <widget class="QPushButton" name="prevStudyButton">
+             <widget class="QPushButton" name="PrevStudyButton">
               <property name="sizePolicy">
                <sizepolicy hsizetype="Preferred" vsizetype="Preferred">
                 <horstretch>32</horstretch>
@@ -169,7 +172,7 @@
              </widget>
             </item>
             <item>
-             <widget class="QPushButton" name="prevSeriesButton">
+             <widget class="QPushButton" name="PrevSeriesButton">
               <property name="sizePolicy">
                <sizepolicy hsizetype="Preferred" vsizetype="Preferred">
                 <horstretch>32</horstretch>
@@ -191,7 +194,7 @@
              </widget>
             </item>
             <item>
-             <widget class="QPushButton" name="prevImageButton">
+             <widget class="QPushButton" name="PrevImageButton">
               <property name="sizePolicy">
                <sizepolicy hsizetype="Preferred" vsizetype="Preferred">
                 <horstretch>32</horstretch>
@@ -213,7 +216,7 @@
              </widget>
             </item>
             <item>
-             <widget class="QPushButton" name="nextImageButton">
+             <widget class="QPushButton" name="NextImageButton">
               <property name="sizePolicy">
                <sizepolicy hsizetype="Preferred" vsizetype="Preferred">
                 <horstretch>32</horstretch>
@@ -235,7 +238,7 @@
              </widget>
             </item>
             <item>
-             <widget class="QPushButton" name="nextSeriesButton">
+             <widget class="QPushButton" name="NextSeriesButton">
               <property name="sizePolicy">
                <sizepolicy hsizetype="Preferred" vsizetype="Preferred">
                 <horstretch>32</horstretch>
@@ -257,7 +260,7 @@
              </widget>
             </item>
             <item>
-             <widget class="QPushButton" name="nextStudyButton">
+             <widget class="QPushButton" name="NextStudyButton">
               <property name="sizePolicy">
                <sizepolicy hsizetype="Preferred" vsizetype="Preferred">
                 <horstretch>32</horstretch>
@@ -293,14 +296,14 @@
           <item>
            <layout class="QHBoxLayout" name="horizontalLayout_2">
             <item>
-             <widget class="QCheckBox" name="autoPlayCheckbox">
+             <widget class="QCheckBox" name="AutoPlayCheckbox">
               <property name="text">
                <string>auto-play</string>
               </property>
              </widget>
             </item>
             <item>
-             <widget class="QSlider" name="playSlider">
+             <widget class="QSlider" name="PlaySlider">
               <property name="sizePolicy">
                <sizepolicy hsizetype="Preferred" vsizetype="Fixed">
                 <horstretch>0</horstretch>
@@ -322,7 +325,7 @@
     </layout>
    </item>
   </layout>
-  <action name="actionImport">
+  <action name="ActionImport">
    <property name="text">
     <string>Import</string>
    </property>
@@ -330,7 +333,7 @@
     <string>Import a DICOM file or folder</string>
    </property>
   </action>
-  <action name="actionExport">
+  <action name="ActionExport">
    <property name="enabled">
     <bool>false</bool>
    </property>
@@ -341,7 +344,7 @@
     <string>Export selected study/series to a DICOM folder (not yet available)</string>
    </property>
   </action>
-  <action name="actionQuery">
+  <action name="ActionQuery">
    <property name="text">
     <string>Query</string>
    </property>
@@ -349,7 +352,7 @@
     <string>Query and Retrieve DICOM studies from a DICOM node</string>
    </property>
   </action>
-  <action name="actionSend">
+  <action name="ActionSend">
    <property name="enabled">
     <bool>false</bool>
    </property>
@@ -393,7 +396,7 @@
  <resources/>
  <connections>
   <connection>
-   <sender>actionImport</sender>
+   <sender>ActionImport</sender>
    <signal>triggered(bool)</signal>
    <receiver>ctkDICOMAppWidget</receiver>
    <slot>openImportDialog()</slot>
@@ -409,7 +412,7 @@
    </hints>
   </connection>
   <connection>
-   <sender>actionExport</sender>
+   <sender>ActionExport</sender>
    <signal>triggered(bool)</signal>
    <receiver>ctkDICOMAppWidget</receiver>
    <slot>openExportDialog()</slot>
@@ -425,7 +428,7 @@
    </hints>
   </connection>
   <connection>
-   <sender>actionQuery</sender>
+   <sender>ActionQuery</sender>
    <signal>triggered(bool)</signal>
    <receiver>ctkDICOMAppWidget</receiver>
    <slot>openQueryDialog()</slot>
@@ -441,7 +444,7 @@
    </hints>
   </connection>
   <connection>
-   <sender>nextImageButton</sender>
+   <sender>NextImageButton</sender>
    <signal>clicked()</signal>
    <receiver>ctkDICOMAppWidget</receiver>
    <slot>onNextImage()</slot>
@@ -457,7 +460,7 @@
    </hints>
   </connection>
   <connection>
-   <sender>prevImageButton</sender>
+   <sender>PrevImageButton</sender>
    <signal>clicked()</signal>
    <receiver>ctkDICOMAppWidget</receiver>
    <slot>onPreviousImage()</slot>
@@ -473,7 +476,7 @@
    </hints>
   </connection>
   <connection>
-   <sender>nextSeriesButton</sender>
+   <sender>NextSeriesButton</sender>
    <signal>clicked()</signal>
    <receiver>ctkDICOMAppWidget</receiver>
    <slot>onNextSeries()</slot>
@@ -489,7 +492,7 @@
    </hints>
   </connection>
   <connection>
-   <sender>prevSeriesButton</sender>
+   <sender>PrevSeriesButton</sender>
    <signal>clicked()</signal>
    <receiver>ctkDICOMAppWidget</receiver>
    <slot>onPreviousSeries()</slot>
@@ -505,7 +508,7 @@
    </hints>
   </connection>
   <connection>
-   <sender>nextStudyButton</sender>
+   <sender>NextStudyButton</sender>
    <signal>clicked()</signal>
    <receiver>ctkDICOMAppWidget</receiver>
    <slot>onNextStudy()</slot>
@@ -521,7 +524,7 @@
    </hints>
   </connection>
   <connection>
-   <sender>prevStudyButton</sender>
+   <sender>PrevStudyButton</sender>
    <signal>clicked()</signal>
    <receiver>ctkDICOMAppWidget</receiver>
    <slot>onPreviousStudy()</slot>
@@ -537,7 +540,7 @@
    </hints>
   </connection>
   <connection>
-   <sender>autoPlayCheckbox</sender>
+   <sender>AutoPlayCheckbox</sender>
    <signal>stateChanged(int)</signal>
    <receiver>ctkDICOMAppWidget</receiver>
    <slot>onAutoPlayCheckboxStateChanged(int)</slot>

+ 2 - 2
Libs/DICOM/Widgets/Resources/UI/ctkDICOMThumbnailListWidget.ui

@@ -15,11 +15,11 @@
   </property>
   <layout class="QVBoxLayout" name="verticalLayout_2">
    <item>
-    <widget class="QScrollArea" name="scrollArea">
+    <widget class="QScrollArea" name="ScrollArea">
      <property name="widgetResizable">
       <bool>true</bool>
      </property>
-     <widget class="QWidget" name="scrollAreaContentWidget">
+     <widget class="QWidget" name="ScrollAreaContentWidget">
       <property name="geometry">
        <rect>
         <x>0</x>

+ 2 - 2
Libs/DICOM/Widgets/Resources/UI/ctkDICOMThumbnailWidget.ui

@@ -18,7 +18,7 @@
   </property>
   <layout class="QVBoxLayout" name="verticalLayout_2">
    <item>
-    <widget class="QLabel" name="textLabel">
+    <widget class="QLabel" name="TextLabel">
      <property name="minimumSize">
       <size>
        <width>0</width>
@@ -37,7 +37,7 @@
     </widget>
    </item>
    <item>
-    <widget class="QLabel" name="pixmapLabel">
+    <widget class="QLabel" name="PixmapLabel">
      <property name="sizePolicy">
       <sizepolicy hsizetype="Expanding" vsizetype="Expanding">
        <horstretch>128</horstretch>

+ 132 - 132
Libs/DICOM/Widgets/ctkDICOMAppWidget.cpp

@@ -24,14 +24,14 @@
 #include <dcmimage.h>
 
 // Qt includes
-#include <QDebug>
-#include <QTreeView>
-#include <QTabBar>
-#include <QSettings>
 #include <QAction>
-#include <QModelIndex>
 #include <QCheckBox>
+#include <QDebug>
+#include <QModelIndex>
+#include <QSettings>
+#include <QTabBar>
 #include <QTimer>
+#include <QTreeView>
 
 // ctkWidgets includes
 #include "ctkDirectoryButton.h"
@@ -39,18 +39,18 @@
 
 // ctkDICOMCore includes
 #include "ctkDICOMDatabase.h"
+#include "ctkDICOMFilterProxyModel.h"
 #include "ctkDICOMIndexer.h"
 #include "ctkDICOMModel.h"
-#include "ctkDICOMFilterProxyModel.h"
 
 // ctkDICOMWidgets includes
 #include "ctkDICOMAppWidget.h"
+#include "ctkDICOMImportWidget.h"
+#include "ctkDICOMThumbnailGenerator.h"
+#include "ctkDICOMThumbnailWidget.h"
 #include "ctkDICOMQueryResultsTabWidget.h"
 #include "ctkDICOMQueryRetrieveWidget.h"
 #include "ctkDICOMQueryWidget.h"
-#include "ctkDICOMImportWidget.h"
-#include "ctkDICOMThumbnailWidget.h"
-#include "ctkDICOMThumbnailGenerator.h"
 
 #include "ui_ctkDICOMAppWidget.h"
 
@@ -67,29 +67,27 @@ public:
 
   ctkDICOMAppWidgetPrivate(ctkDICOMAppWidget* );
 
-  ctkFileDialog* importDIalog;
+  ctkFileDialog* ImportDialog;
   ctkDICOMQueryRetrieveWidget* QueryRetrieveWidget;
 
-  QSharedPointer<ctkDICOMDatabase> dicomDatabase;
-  QSharedPointer<ctkDICOMThumbnailGenerator> thumbnailGenerator;
-  ctkDICOMModel dicomModel;
-  ctkDICOMFilterProxyModel dicomProxyModel;
-  QSharedPointer<ctkDICOMIndexer> dicomIndexer;
+  QSharedPointer<ctkDICOMDatabase> DICOMDatabase;
+  QSharedPointer<ctkDICOMThumbnailGenerator> ThumbnailGenerator;
+  ctkDICOMModel DICOMModel;
+  ctkDICOMFilterProxyModel DICOMProxyModel;
+  QSharedPointer<ctkDICOMIndexer> DICOMIndexer;
 
-  bool isAutoPlay;
-  QTimer* autoPlayTimer;
+  QTimer* AutoPlayTimer;
 };
 
 //----------------------------------------------------------------------------
 // ctkDICOMAppWidgetPrivate methods
 
 ctkDICOMAppWidgetPrivate::ctkDICOMAppWidgetPrivate(ctkDICOMAppWidget* parent): q_ptr(parent){
-  dicomDatabase = QSharedPointer<ctkDICOMDatabase> (new ctkDICOMDatabase);
-  thumbnailGenerator = QSharedPointer <ctkDICOMThumbnailGenerator> (new ctkDICOMThumbnailGenerator);
-  dicomDatabase->setThumbnailGenerator(thumbnailGenerator.data());
-  dicomIndexer = QSharedPointer<ctkDICOMIndexer> (new ctkDICOMIndexer);
-  dicomIndexer->setThumbnailGenerator(thumbnailGenerator.data());
-  this->isAutoPlay = false;
+  DICOMDatabase = QSharedPointer<ctkDICOMDatabase> (new ctkDICOMDatabase);
+  ThumbnailGenerator = QSharedPointer <ctkDICOMThumbnailGenerator> (new ctkDICOMThumbnailGenerator);
+  DICOMDatabase->setThumbnailGenerator(ThumbnailGenerator.data());
+  DICOMIndexer = QSharedPointer<ctkDICOMIndexer> (new ctkDICOMIndexer);
+  DICOMIndexer->setThumbnailGenerator(ThumbnailGenerator.data());
 }
 
 //----------------------------------------------------------------------------
@@ -104,24 +102,24 @@ ctkDICOMAppWidget::ctkDICOMAppWidget(QWidget* _parent):Superclass(_parent),
   d->setupUi(this);
 
   //Hide image previewer buttons
-  d->nextImageButton->hide();
-  d->prevImageButton->hide();
-  d->nextSeriesButton->hide();
-  d->prevSeriesButton->hide();
-  d->nextStudyButton->hide();
-  d->prevStudyButton->hide();
+  d->NextImageButton->hide();
+  d->PrevImageButton->hide();
+  d->NextSeriesButton->hide();
+  d->PrevSeriesButton->hide();
+  d->NextStudyButton->hide();
+  d->PrevStudyButton->hide();
 
   //Enable sorting in tree view
-  d->treeView->setSortingEnabled(true);
-  d->treeView->setSelectionBehavior(QAbstractItemView::SelectRows);
-  d->dicomProxyModel.setSourceModel(&d->dicomModel);
-  d->treeView->setModel(&d->dicomProxyModel);
+  d->TreeView->setSortingEnabled(true);
+  d->TreeView->setSelectionBehavior(QAbstractItemView::SelectRows);
+  d->DICOMProxyModel.setSourceModel(&d->DICOMModel);
+  d->TreeView->setModel(&d->DICOMModel);
 
-  connect(d->treeView, SIGNAL(collapsed(QModelIndex)), this, SLOT(onTreeCollapsed(QModelIndex)));
-  connect(d->treeView, SIGNAL(expanded(QModelIndex)), this, SLOT(onTreeExpanded(QModelIndex)));
+  connect(d->TreeView, SIGNAL(collapsed(QModelIndex)), this, SLOT(onTreeCollapsed(QModelIndex)));
+  connect(d->TreeView, SIGNAL(expanded(QModelIndex)), this, SLOT(onTreeExpanded(QModelIndex)));
 
-  //Set toolbar button style
-  d->toolBar->setToolButtonStyle(Qt::ToolButtonTextUnderIcon);
+  //Set ToolBar button style
+  d->ToolBar->setToolButtonStyle(Qt::ToolButtonTextUnderIcon);
 
   //Initialize Q/R widget
   d->QueryRetrieveWidget = new ctkDICOMQueryRetrieveWidget();
@@ -137,38 +135,38 @@ ctkDICOMAppWidget::ctkDICOMAppWidget(QWidget* _parent):Superclass(_parent),
     }
   QString databaseDirectory = settings.value("DatabaseDirectory").toString();
   this->setDatabaseDirectory(databaseDirectory);
-  d->directoryButton->setDirectory(databaseDirectory);
+  d->DirectoryButton->setDirectory(databaseDirectory);
 
-  connect(d->directoryButton, SIGNAL(directoryChanged(const QString&)), this, SLOT(setDatabaseDirectory(const QString&)));
+  connect(d->DirectoryButton, SIGNAL(directoryChanged(const QString&)), this, SLOT(setDatabaseDirectory(const QString&)));
 
   //Initialize import widget
-  d->importDIalog = new ctkFileDialog();
-  QCheckBox* importCheckbox = new QCheckBox("Copy on import", d->importDIalog);
-  d->importDIalog->setBottomWidget(importCheckbox);
-  d->importDIalog->setFileMode(QFileDialog::Directory);
-  d->importDIalog->setLabelText(QFileDialog::Accept,"Import");
-  d->importDIalog->setWindowTitle("Import DICOM files from directory ...");
-  d->importDIalog->setWindowModality(Qt::ApplicationModal);
+  d->ImportDialog = new ctkFileDialog();
+  QCheckBox* importCheckbox = new QCheckBox("Copy on import", d->ImportDialog);
+  d->ImportDialog->setBottomWidget(importCheckbox);
+  d->ImportDialog->setFileMode(QFileDialog::Directory);
+  d->ImportDialog->setLabelText(QFileDialog::Accept,"Import");
+  d->ImportDialog->setWindowTitle("Import DICOM files from directory ...");
+  d->ImportDialog->setWindowModality(Qt::ApplicationModal);
 
   //connect signal and slots
-  connect(d->treeView, SIGNAL(clicked(const QModelIndex&)), d->thumbnailsWidget, SLOT(onModelSelected(const QModelIndex &)));
-  connect(d->treeView, SIGNAL(clicked(const QModelIndex&)), d->imagePreview, SLOT(onModelSelected(const QModelIndex &)));
-  connect(d->treeView, SIGNAL(clicked(const QModelIndex&)), this, SLOT(onModelSelected(const QModelIndex &)));
+  connect(d->TreeView, SIGNAL(clicked(const QModelIndex&)), d->ThumbnailsWidget, SLOT(onModelSelected(const QModelIndex &)));
+  connect(d->TreeView, SIGNAL(clicked(const QModelIndex&)), d->imagePreview, SLOT(onModelSelected(const QModelIndex &)));
+  connect(d->TreeView, SIGNAL(clicked(const QModelIndex&)), this, SLOT(onModelSelected(const QModelIndex &)));
 
-  connect(d->thumbnailsWidget, SIGNAL(selected(const ctkDICOMThumbnailWidget&)), this, SLOT(onThumbnailSelected(const ctkDICOMThumbnailWidget&)));
-  connect(d->thumbnailsWidget, SIGNAL(doubleClicked(const ctkDICOMThumbnailWidget&)), this, SLOT(onThumbnailDoubleClicked(const ctkDICOMThumbnailWidget&)));
-  connect(d->importDIalog, SIGNAL(fileSelected(QString)),this,SLOT(onImportDirectory(QString)));
+  connect(d->ThumbnailsWidget, SIGNAL(selected(const ctkDICOMThumbnailWidget&)), this, SLOT(onThumbnailSelected(const ctkDICOMThumbnailWidget&)));
+  connect(d->ThumbnailsWidget, SIGNAL(doubleClicked(const ctkDICOMThumbnailWidget&)), this, SLOT(onThumbnailDoubleClicked(const ctkDICOMThumbnailWidget&)));
+  connect(d->ImportDialog, SIGNAL(fileSelected(QString)),this,SLOT(onImportDirectory(QString)));
 
-  connect(d->dicomDatabase.data(), SIGNAL( databaseChanged() ), &(d->dicomModel), SLOT( reset() ) );
+  connect(d->DICOMDatabase.data(), SIGNAL( databaseChanged() ), &(d->DICOMModel), SLOT( reset() ) );
   connect(d->QueryRetrieveWidget, SIGNAL( canceled() ), d->QueryRetrieveWidget, SLOT( hide() ) );
 
   connect(d->imagePreview, SIGNAL(requestNextImage()), this, SLOT(onNextImage()));
   connect(d->imagePreview, SIGNAL(requestPreviousImage()), this, SLOT(onPreviousImage()));
 
-  connect(d->searchOption, SIGNAL(nameSearchTextChanged(QString)), &(d->dicomProxyModel), SLOT(setNameSearchText(QString)));
-  connect(d->searchOption, SIGNAL(studySearchTextChanged(QString)), &(d->dicomProxyModel), SLOT(setStudySearchText(QString)));
-  connect(d->searchOption, SIGNAL(seriesSearchTextChanged(QString)), &(d->dicomProxyModel), SLOT(setSeriesSearchText(QString)));
-  connect(d->searchOption, SIGNAL(idSearchTextChanged(QString)), &(d->dicomProxyModel), SLOT(setIdSearchText(QString)));
+  connect(d->SearchOption, SIGNAL(nameSearchTextChanged(QString)), &(d->DICOMProxyModel), SLOT(setNameSearchText(QString)));
+  connect(d->SearchOption, SIGNAL(studySearchTextChanged(QString)), &(d->DICOMProxyModel), SLOT(setStudySearchText(QString)));
+  connect(d->SearchOption, SIGNAL(seriesSearchTextChanged(QString)), &(d->DICOMProxyModel), SLOT(setSeriesSearchText(QString)));
+  connect(d->SearchOption, SIGNAL(idSearchTextChanged(QString)), &(d->DICOMProxyModel), SLOT(setIdSearchText(QString)));
 
 }
 
@@ -178,7 +176,7 @@ ctkDICOMAppWidget::~ctkDICOMAppWidget()
   Q_D(ctkDICOMAppWidget);  
 
   d->QueryRetrieveWidget->deleteLater();
-  d->importDIalog->deleteLater();
+  d->ImportDialog->deleteLater();
 }
 
 //----------------------------------------------------------------------------
@@ -191,29 +189,29 @@ void ctkDICOMAppWidget::setDatabaseDirectory(const QString& directory)
   settings.sync();
 
   //close the active DICOM database
-  d->dicomDatabase->closeDatabase();
+  d->DICOMDatabase->closeDatabase();
   
   //open DICOM database on the directory
   QString databaseFileName = directory + QString("/ctkDICOM.sql");
-  try { d->dicomDatabase->openDatabase( databaseFileName ); }
+  try { d->DICOMDatabase->openDatabase( databaseFileName ); }
   catch (std::exception e)
   {
-    std::cerr << "Database error: " << qPrintable(d->dicomDatabase->lastError()) << "\n";
-    d->dicomDatabase->closeDatabase();
+    std::cerr << "Database error: " << qPrintable(d->DICOMDatabase->lastError()) << "\n";
+    d->DICOMDatabase->closeDatabase();
     return;
   }
   
-  d->dicomModel.setDatabase(d->dicomDatabase->database());
-  d->dicomModel.setDisplayLevel(ctkDICOMModel::SeriesType);
-  d->treeView->resizeColumnToContents(0);
+  d->DICOMModel.setDatabase(d->DICOMDatabase->database());
+  d->DICOMModel.setDisplayLevel(ctkDICOMModel::SeriesType);
+  d->TreeView->resizeColumnToContents(0);
 
   //pass DICOM database instance to Import widget
-  // d->importDIalog->setdicomDatabase(d->dicomDatabase);
-  d->QueryRetrieveWidget->setRetrieveDatabase(d->dicomDatabase);
+  // d->ImportDialog->setDICOMDatabase(d->DICOMDatabase);
+  d->QueryRetrieveWidget->setRetrieveDatabase(d->DICOMDatabase);
 
   // update the button and let any connected slots know about the change
-  d->directoryButton->setDirectory(directory);
-  d->thumbnailsWidget->setDatabaseDirectory(directory);
+  d->DirectoryButton->setDirectory(directory);
+  d->ThumbnailsWidget->setDatabaseDirectory(directory);
   d->imagePreview->setDatabaseDirectory(directory);
   emit databaseDirectoryChanged(directory);
 }
@@ -237,8 +235,8 @@ void ctkDICOMAppWidget::openImportDialog()
 {
   Q_D(ctkDICOMAppWidget);
   
-  d->importDIalog->show();
-  d->importDIalog->raise();
+  d->ImportDialog->show();
+  d->ImportDialog->raise();
 }
 
 //----------------------------------------------------------------------------
@@ -273,13 +271,13 @@ void ctkDICOMAppWidget::onThumbnailDoubleClicked(const ctkDICOMThumbnailWidget&
     logger.debug("double clicked");
     QModelIndex index = widget.sourceIndex();
 
-    ctkDICOMFilterProxyModel* model = const_cast<ctkDICOMFilterProxyModel*>(qobject_cast<const ctkDICOMFilterProxyModel*>(index.model()));
+    ctkDICOMModel* model = const_cast<ctkDICOMModel*>(qobject_cast<const ctkDICOMModel*>(index.model()));
     QModelIndex index0 = index.sibling(index.row(), 0);
 
-    if(model && (model->data(index0,ctkDICOMModel::TypeRole) != ctkDICOMModel::ImageType)){
+    if(model && (model->data(index0,ctkDICOMModel::TypeRole) != static_cast<int>(ctkDICOMModel::ImageType))){
         this->onModelSelected(index0);
-        d->treeView->setCurrentIndex(index0);
-        d->thumbnailsWidget->onModelSelected(index0);
+        d->TreeView->setCurrentIndex(index0);
+        d->ThumbnailsWidget->onModelSelected(index0);
         d->imagePreview->onModelSelected(index0);
     }
 }
@@ -290,14 +288,14 @@ void ctkDICOMAppWidget::onImportDirectory(QString directory)
   Q_D(ctkDICOMAppWidget);
   if (QDir(directory).exists())
   {
-    QCheckBox* copyOnImport = qobject_cast<QCheckBox*>(d->importDIalog->bottomWidget());
+    QCheckBox* copyOnImport = qobject_cast<QCheckBox*>(d->ImportDialog->bottomWidget());
     QString targetDirectory;
     if (copyOnImport->isEnabled())
     {
-       targetDirectory = d->dicomDatabase->databaseDirectory();
+       targetDirectory = d->DICOMDatabase->databaseDirectory();
     }
-    d->dicomIndexer->addDirectory(*d->dicomDatabase,directory,targetDirectory);
-    d->dicomModel.reset();
+    d->DICOMIndexer->addDirectory(*d->DICOMDatabase,directory,targetDirectory);
+    d->DICOMModel.reset();
   }
 }
 
@@ -305,47 +303,47 @@ void ctkDICOMAppWidget::onImportDirectory(QString directory)
 void ctkDICOMAppWidget::onModelSelected(const QModelIndex &index){
     Q_D(ctkDICOMAppWidget);
 
-    ctkDICOMFilterProxyModel* model = const_cast<ctkDICOMFilterProxyModel*>(qobject_cast<const ctkDICOMFilterProxyModel*>(index.model()));
+    ctkDICOMModel* model = const_cast<ctkDICOMModel*>(qobject_cast<const ctkDICOMModel*>(index.model()));
 
     if(model){
         QModelIndex index0 = index.sibling(index.row(), 0);
 
-        if ( model->data(index0,ctkDICOMModel::TypeRole) == ctkDICOMModel::PatientType ){
-            d->nextImageButton->show();
-            d->prevImageButton->show();
-            d->nextSeriesButton->show();
-            d->prevSeriesButton->show();
-            d->nextStudyButton->show();
-            d->prevStudyButton->show();
-        }else if ( model->data(index0,ctkDICOMModel::TypeRole) == ctkDICOMModel::StudyType ){
-            d->nextImageButton->show();
-            d->prevImageButton->show();
-            d->nextSeriesButton->show();
-            d->prevSeriesButton->show();
-            d->nextStudyButton->hide();
-            d->prevStudyButton->hide();
-        }else if ( model->data(index0,ctkDICOMModel::TypeRole) == ctkDICOMModel::SeriesType ){
-            d->nextImageButton->show();
-            d->prevImageButton->show();
-            d->nextSeriesButton->hide();
-            d->prevSeriesButton->hide();
-            d->nextStudyButton->hide();
-            d->prevStudyButton->hide();
+        if ( model->data(index0,ctkDICOMModel::TypeRole) == static_cast<int>(ctkDICOMModel::PatientType) ){
+            d->NextImageButton->show();
+            d->PrevImageButton->show();
+            d->NextSeriesButton->show();
+            d->PrevSeriesButton->show();
+            d->NextStudyButton->show();
+            d->PrevStudyButton->show();
+        }else if ( model->data(index0,ctkDICOMModel::TypeRole) == static_cast<int>(ctkDICOMModel::StudyType) ){
+            d->NextImageButton->show();
+            d->PrevImageButton->show();
+            d->NextSeriesButton->show();
+            d->PrevSeriesButton->show();
+            d->NextStudyButton->hide();
+            d->PrevStudyButton->hide();
+        }else if ( model->data(index0,ctkDICOMModel::TypeRole) == static_cast<int>(ctkDICOMModel::SeriesType) ){
+            d->NextImageButton->show();
+            d->PrevImageButton->show();
+            d->NextSeriesButton->hide();
+            d->PrevSeriesButton->hide();
+            d->NextStudyButton->hide();
+            d->PrevStudyButton->hide();
         }else{
-            d->nextImageButton->hide();
-            d->prevImageButton->hide();
-            d->nextSeriesButton->hide();
-            d->prevSeriesButton->hide();
-            d->nextStudyButton->hide();
-            d->prevStudyButton->hide();
+            d->NextImageButton->hide();
+            d->PrevImageButton->hide();
+            d->NextSeriesButton->hide();
+            d->PrevSeriesButton->hide();
+            d->NextStudyButton->hide();
+            d->PrevStudyButton->hide();
         }
     }else{
-        d->nextImageButton->hide();
-        d->prevImageButton->hide();
-        d->nextSeriesButton->hide();
-        d->prevSeriesButton->hide();
-        d->nextStudyButton->hide();
-        d->prevStudyButton->hide();
+        d->NextImageButton->hide();
+        d->PrevImageButton->hide();
+        d->NextSeriesButton->hide();
+        d->PrevSeriesButton->hide();
+        d->NextStudyButton->hide();
+        d->PrevStudyButton->hide();
     }
 }
 
@@ -356,7 +354,7 @@ void ctkDICOMAppWidget::onNextImage(){
     QModelIndex currentIndex = d->imagePreview->currentImageIndex();
 
     if(currentIndex.isValid()){
-        ctkDICOMFilterProxyModel* model = const_cast<ctkDICOMFilterProxyModel*>(qobject_cast<const ctkDICOMFilterProxyModel*>(currentIndex.model()));
+        ctkDICOMModel* model = const_cast<ctkDICOMModel*>(qobject_cast<const ctkDICOMModel*>(currentIndex.model()));
 
         if(model){
             QModelIndex seriesIndex = currentIndex.parent();
@@ -369,7 +367,7 @@ void ctkDICOMAppWidget::onNextImage(){
             QModelIndex nextIndex = currentIndex.sibling(imageID, 0);
 
             d->imagePreview->onModelSelected(nextIndex);
-            d->thumbnailsWidget->selectThumbnail(nextIndex);
+            d->ThumbnailsWidget->selectThumbnail(nextIndex);
         }
     }
 }
@@ -381,7 +379,7 @@ void ctkDICOMAppWidget::onPreviousImage(){
     QModelIndex currentIndex = d->imagePreview->currentImageIndex();
 
     if(currentIndex.isValid()){
-        ctkDICOMFilterProxyModel* model = const_cast<ctkDICOMFilterProxyModel*>(qobject_cast<const ctkDICOMFilterProxyModel*>(currentIndex.model()));
+        ctkDICOMModel* model = const_cast<ctkDICOMModel*>(qobject_cast<const ctkDICOMModel*>(currentIndex.model()));
 
         if(model){
             QModelIndex seriesIndex = currentIndex.parent();
@@ -395,7 +393,7 @@ void ctkDICOMAppWidget::onPreviousImage(){
             QModelIndex prevIndex = currentIndex.sibling(imageID, 0);
 
             d->imagePreview->onModelSelected(prevIndex);
-            d->thumbnailsWidget->selectThumbnail(prevIndex);
+            d->ThumbnailsWidget->selectThumbnail(prevIndex);
         }
     }
 }
@@ -407,7 +405,7 @@ void ctkDICOMAppWidget::onNextSeries(){
     QModelIndex currentIndex = d->imagePreview->currentImageIndex();
 
     if(currentIndex.isValid()){
-        ctkDICOMFilterProxyModel* model = const_cast<ctkDICOMFilterProxyModel*>(qobject_cast<const ctkDICOMFilterProxyModel*>(currentIndex.model()));
+        ctkDICOMModel* model = const_cast<ctkDICOMModel*>(qobject_cast<const ctkDICOMModel*>(currentIndex.model()));
 
         if(model){
             QModelIndex seriesIndex = currentIndex.parent();
@@ -421,7 +419,7 @@ void ctkDICOMAppWidget::onNextSeries(){
             QModelIndex nextIndex = seriesIndex.sibling(seriesID, 0);
 
             d->imagePreview->onModelSelected(nextIndex);
-            d->thumbnailsWidget->selectThumbnail(nextIndex);
+            d->ThumbnailsWidget->selectThumbnail(nextIndex);
         }
     }
 }
@@ -433,7 +431,7 @@ void ctkDICOMAppWidget::onPreviousSeries(){
     QModelIndex currentIndex = d->imagePreview->currentImageIndex();
 
     if(currentIndex.isValid()){
-        ctkDICOMFilterProxyModel* model = const_cast<ctkDICOMFilterProxyModel*>(qobject_cast<const ctkDICOMFilterProxyModel*>(currentIndex.model()));
+        ctkDICOMModel* model = const_cast<ctkDICOMModel*>(qobject_cast<const ctkDICOMModel*>(currentIndex.model()));
 
         if(model){
             QModelIndex seriesIndex = currentIndex.parent();
@@ -448,7 +446,7 @@ void ctkDICOMAppWidget::onPreviousSeries(){
             QModelIndex prevIndex = seriesIndex.sibling(seriesID, 0);
 
             d->imagePreview->onModelSelected(prevIndex);
-            d->thumbnailsWidget->selectThumbnail(prevIndex);
+            d->ThumbnailsWidget->selectThumbnail(prevIndex);
         }
     }
 }
@@ -460,7 +458,7 @@ void ctkDICOMAppWidget::onNextStudy(){
     QModelIndex currentIndex = d->imagePreview->currentImageIndex();
 
     if(currentIndex.isValid()){
-        ctkDICOMFilterProxyModel* model = const_cast<ctkDICOMFilterProxyModel*>(qobject_cast<const ctkDICOMFilterProxyModel*>(currentIndex.model()));
+        ctkDICOMModel* model = const_cast<ctkDICOMModel*>(qobject_cast<const ctkDICOMModel*>(currentIndex.model()));
 
         if(model){
             QModelIndex seriesIndex = currentIndex.parent();
@@ -475,7 +473,7 @@ void ctkDICOMAppWidget::onNextStudy(){
             QModelIndex nextIndex = studyIndex.sibling(studyID, 0);
 
             d->imagePreview->onModelSelected(nextIndex);
-            d->thumbnailsWidget->selectThumbnail(nextIndex);
+            d->ThumbnailsWidget->selectThumbnail(nextIndex);
         }
     }
 }
@@ -487,7 +485,7 @@ void ctkDICOMAppWidget::onPreviousStudy(){
     QModelIndex currentIndex = d->imagePreview->currentImageIndex();
 
     if(currentIndex.isValid()){
-        ctkDICOMFilterProxyModel* model = const_cast<ctkDICOMFilterProxyModel*>(qobject_cast<const ctkDICOMFilterProxyModel*>(currentIndex.model()));
+        ctkDICOMModel* model = const_cast<ctkDICOMModel*>(qobject_cast<const ctkDICOMModel*>(currentIndex.model()));
 
         if(model){
             QModelIndex seriesIndex = currentIndex.parent();
@@ -503,21 +501,23 @@ void ctkDICOMAppWidget::onPreviousStudy(){
             QModelIndex prevIndex = studyIndex.sibling(studyID, 0);
 
             d->imagePreview->onModelSelected(prevIndex);
-            d->thumbnailsWidget->selectThumbnail(prevIndex);
+            d->ThumbnailsWidget->selectThumbnail(prevIndex);
         }
     }
 }
 
 //----------------------------------------------------------------------------
 void ctkDICOMAppWidget::onTreeCollapsed(const QModelIndex &index){
+    Q_UNUSED(index);
     Q_D(ctkDICOMAppWidget);
-    d->treeView->resizeColumnToContents(0);
+    d->TreeView->resizeColumnToContents(0);
 }
 
 //----------------------------------------------------------------------------
 void ctkDICOMAppWidget::onTreeExpanded(const QModelIndex &index){
+    Q_UNUSED(index);
     Q_D(ctkDICOMAppWidget);
-    d->treeView->resizeColumnToContents(0);
+    d->TreeView->resizeColumnToContents(0);
 }
 
 //----------------------------------------------------------------------------
@@ -525,12 +525,12 @@ void ctkDICOMAppWidget::onAutoPlayCheckboxStateChanged(int state){
     Q_D(ctkDICOMAppWidget);
 
     if(state == 0){ //OFF
-        disconnect(d->autoPlayTimer, SIGNAL(timeout()), this, SLOT(onAutoPlayTimer()));
-        d->autoPlayTimer->deleteLater();
+        disconnect(d->AutoPlayTimer, SIGNAL(timeout()), this, SLOT(onAutoPlayTimer()));
+        d->AutoPlayTimer->deleteLater();
     }else if(state == 2){ //ON
-        d->autoPlayTimer = new QTimer(this);
-        connect(d->autoPlayTimer, SIGNAL(timeout()), this, SLOT(onAutoPlayTimer()));
-        d->autoPlayTimer->start(50);
+        d->AutoPlayTimer = new QTimer(this);
+        connect(d->AutoPlayTimer, SIGNAL(timeout()), this, SLOT(onAutoPlayTimer()));
+        d->AutoPlayTimer->start(50);
     }
 }
 

+ 1 - 1
Libs/DICOM/Widgets/ctkDICOMAppWidget.h

@@ -26,9 +26,9 @@
 
 #include "ctkDICOMWidgetsExport.h"
 
-class QModelIndex;
 class ctkDICOMAppWidgetPrivate;
 class ctkDICOMThumbnailWidget;
+class QModelIndex;
 
 class CTK_DICOM_WIDGETS_EXPORT ctkDICOMAppWidget : public QWidget
 {

+ 20 - 17
Libs/DICOM/Widgets/ctkDICOMDatasetView.cpp

@@ -26,20 +26,23 @@
 // CTK includes
 #include "ctkLogger.h"
 #include "ctkQImageView.h"
-#include "ctkDICOMModel.h"
+
+// ctkDICOMCore includes
 #include "ctkDICOMFilterProxyModel.h"
+#include "ctkDICOMModel.h"
+
+// ctkDICOMWidgets includex
 #include "ctkDICOMDatasetView.h"
 
 // Qt includes
-#include <QLabel>
-#include <QHBoxLayout>
 #include <QDebug>
-#include <QResizeEvent>
-#include <QMouseEvent>
-#include <QKeyEvent>
-#include <QPainter>
 #include <QFile>
+#include <QHBoxLayout>
+#include <QKeyEvent>
+#include <QLabel>
 #include <QMouseEvent>
+#include <QPainter>
+#include <QResizeEvent>
 
 static ctkLogger logger("org.commontk.DICOM.Widgets.ctkDICOMDatasetView");
 
@@ -108,7 +111,7 @@ void ctkDICOMDatasetViewPrivate::init()
 void ctkDICOMDatasetViewPrivate::setImage(const QModelIndex &imageIndex, bool defaultIntensity){
     Q_Q(ctkDICOMDatasetView);
 
-    ctkDICOMFilterProxyModel* model = const_cast<ctkDICOMFilterProxyModel*>(qobject_cast<const ctkDICOMFilterProxyModel*>(imageIndex.model()));
+    ctkDICOMModel* model = const_cast<ctkDICOMModel*>(qobject_cast<const ctkDICOMModel*>(imageIndex.model()));
 
     if(model){
         QModelIndex seriesIndex = imageIndex.parent();
@@ -135,7 +138,7 @@ void ctkDICOMDatasetViewPrivate::setImage(const QModelIndex &imageIndex, bool de
 void ctkDICOMDatasetViewPrivate::onPatientModelSelected(const QModelIndex &index){
     Q_Q(ctkDICOMDatasetView);
 
-    ctkDICOMFilterProxyModel* model = const_cast<ctkDICOMFilterProxyModel*>(qobject_cast<const ctkDICOMFilterProxyModel*>(index.model()));
+    ctkDICOMModel* model = const_cast<ctkDICOMModel*>(qobject_cast<const ctkDICOMModel*>(index.model()));
 
     if(model){
         QModelIndex patientIndex = index;
@@ -157,7 +160,7 @@ void ctkDICOMDatasetViewPrivate::onPatientModelSelected(const QModelIndex &index
 void ctkDICOMDatasetViewPrivate::onStudyModelSelected(const QModelIndex &index){
     Q_Q(ctkDICOMDatasetView);
 
-    ctkDICOMFilterProxyModel* model = const_cast<ctkDICOMFilterProxyModel*>(qobject_cast<const ctkDICOMFilterProxyModel*>(index.model()));
+    ctkDICOMModel* model = const_cast<ctkDICOMModel*>(qobject_cast<const ctkDICOMModel*>(index.model()));
 
     if(model){
         QModelIndex studyIndex = index;
@@ -177,7 +180,7 @@ void ctkDICOMDatasetViewPrivate::onStudyModelSelected(const QModelIndex &index){
 void ctkDICOMDatasetViewPrivate::onSeriesModelSelected(const QModelIndex &index){
     Q_Q(ctkDICOMDatasetView);
 
-    ctkDICOMFilterProxyModel* model = const_cast<ctkDICOMFilterProxyModel*>(qobject_cast<const ctkDICOMFilterProxyModel*>(index.model()));
+    ctkDICOMModel* model = const_cast<ctkDICOMModel*>(qobject_cast<const ctkDICOMModel*>(index.model()));
 
     if(model){
         QModelIndex seriesIndex = index;
@@ -195,7 +198,7 @@ void ctkDICOMDatasetViewPrivate::onSeriesModelSelected(const QModelIndex &index)
 void ctkDICOMDatasetViewPrivate::onImageModelSelected(const QModelIndex &index){
     Q_Q(ctkDICOMDatasetView);
 
-    ctkDICOMFilterProxyModel* model = const_cast<ctkDICOMFilterProxyModel*>(qobject_cast<const ctkDICOMFilterProxyModel*>(index.model()));
+    ctkDICOMModel* model = const_cast<ctkDICOMModel*>(qobject_cast<const ctkDICOMModel*>(index.model()));
 
     if(model){
         QModelIndex imageIndex = index;
@@ -343,19 +346,19 @@ void ctkDICOMDatasetView::mouseMoveEvent(QMouseEvent* event){
 void ctkDICOMDatasetView::onModelSelected(const QModelIndex &index){
     Q_D(ctkDICOMDatasetView);
 
-    ctkDICOMFilterProxyModel* model = const_cast<ctkDICOMFilterProxyModel*>(qobject_cast<const ctkDICOMFilterProxyModel*>(index.model()));
+    ctkDICOMModel* model = const_cast<ctkDICOMModel*>(qobject_cast<const ctkDICOMModel*>(index.model()));
 
     if(model){
         QModelIndex index0 = index.sibling(index.row(), 0);
 
 
-        if ( model->data(index0,ctkDICOMModel::TypeRole) == ctkDICOMModel::PatientType ){
+        if ( model->data(index0,ctkDICOMModel::TypeRole) == static_cast<int>(ctkDICOMModel::PatientType) ){
             d->onPatientModelSelected(index0);
-        }else if ( model->data(index0,ctkDICOMModel::TypeRole) == ctkDICOMModel::StudyType ){
+        }else if ( model->data(index0,ctkDICOMModel::TypeRole) == static_cast<int>(ctkDICOMModel::StudyType) ){
             d->onStudyModelSelected(index0);
-        }else if ( model->data(index0,ctkDICOMModel::TypeRole) == ctkDICOMModel::SeriesType ){
+        }else if ( model->data(index0,ctkDICOMModel::TypeRole) == static_cast<int>(ctkDICOMModel::SeriesType) ){
             d->onSeriesModelSelected(index0);
-        }else if ( model->data(index0,ctkDICOMModel::TypeRole) == ctkDICOMModel::ImageType ){
+        }else if ( model->data(index0,ctkDICOMModel::TypeRole) == static_cast<int>(ctkDICOMModel::ImageType) ){
             d->onImageModelSelected(index0);
         }
     }

+ 1 - 1
Libs/DICOM/Widgets/ctkDICOMQueryRetrieveWidget.cpp

@@ -190,7 +190,7 @@ void ctkDICOMQueryRetrieveWidget::query()
     QMap<QString, QVariant> parameters =
       d->ServerNodeWidget->serverNodeParameters(d->CurrentServer);
     // if we are here it's because the server node was checked
-    Q_ASSERT(parameters["CheckState"] == Qt::Checked );
+    Q_ASSERT(parameters["CheckState"] == static_cast<int>(Qt::Checked) );
     // create a query for the current server
     ctkDICOMQuery* query = new ctkDICOMQuery;
     query->setCallingAETitle(d->ServerNodeWidget->callingAETitle());

+ 7 - 3
Libs/DICOM/Widgets/ctkDICOMThumbnailGenerator.cpp

@@ -69,9 +69,11 @@ ctkDICOMThumbnailGenerator::~ctkDICOMThumbnailGenerator()
 {
 }
 
+//------------------------------------------------------------------------------
 bool ctkDICOMThumbnailGenerator::generateThumbnail(DicomImage *dcmImage, const QString &path){
     QImage image;
-    if ((dcmImage->getStatus() == EIS_Normal)){
+    if ((dcmImage->getStatus() == EIS_Normal))
+    {
         dcmImage->setWindow(0);
         /* get image extension */
         const unsigned long width = dcmImage->getWidth();
@@ -86,8 +88,10 @@ bool ctkDICOMThumbnailGenerator::generateThumbnail(DicomImage *dcmImage, const Q
 
         /* copy PGM header to buffer */
 
-        if (dcmImage->getOutputData(static_cast<void *>(buffer.data() + offset), length - offset, 8, 0)){
-            if (!image.loadFromData( buffer )){
+        if (dcmImage->getOutputData(static_cast<void *>(buffer.data() + offset), length - offset, 8, 0))
+        {
+            if (!image.loadFromData( buffer ))
+            {
                 logger.error("QImage couldn't created");
                 return false;
             }

+ 102 - 64
Libs/DICOM/Widgets/ctkDICOMThumbnailListWidget.cpp

@@ -1,13 +1,32 @@
+/*=========================================================================
+
+  Library:   CTK
+
+  Copyright (c) Kitware Inc.
+
+  Licensed under the Apache License, Version 2.0 (the "License");
+  you may not use this file except in compliance with the License.
+  You may obtain a copy of the License at
+
+      http://www.commontk.org/LICENSE
+
+  Unless required by applicable law or agreed to in writing, software
+  distributed under the License is distributed on an "AS IS" BASIS,
+  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+  See the License for the specific language governing permissions and
+  limitations under the License.
+
+=========================================================================*/
 
 // Qt include
-#include <QGridLayout>
-#include <QResizeEvent>
-#include <QPushButton>
-#include <QPixmap>
+#include <QDateTime>
 #include <QDir>
 #include <QFile>
 #include <QFileInfo>
-#include <QDateTime>
+#include <QGridLayout>
+#include <QPixmap>
+#include <QPushButton>
+#include <QResizeEvent>
 
 // ctk includes
 #include "ctkLogger.h"
@@ -16,14 +35,14 @@
 #include "ctkFlowLayout.h"
 
 //ctkDICOMCore includes
-#include "ctkDICOMModel.h"
 #include "ctkDICOMDatabase.h"
 #include "ctkDICOMFilterProxyModel.h"
+#include "ctkDICOMModel.h"
 
 // ctkDICOMWidgets includes
 #include "ctkDICOMThumbnailListWidget.h"
-#include "ui_ctkDICOMThumbnailListWidget.h"
 #include "ctkDICOMThumbnailWidget.h"
+#include "ui_ctkDICOMThumbnailListWidget.h"
 
 // STD includes
 #include <iostream>
@@ -41,9 +60,8 @@ public:
     
   }
 
-  QString databaseDirectory;
-
-  QModelIndex currentSelectedModel;
+  QString DatabaseDirectory;
+  QModelIndex CurrentSelectedModel;
 
   void clearAllThumbnails();
   void addThumbnailWidget(const QModelIndex &imageIndex, const QModelIndex& sourceIndex, const QString& text);
@@ -60,29 +78,30 @@ public:
 // ctkDICOMThumbnailListWidgetPrivate methods
 
 void ctkDICOMThumbnailListWidgetPrivate::onPatientModelSelected(const QModelIndex &index){
-    Q_Q(ctkDICOMThumbnailListWidget);
-
     QModelIndex patientIndex = index;
 
-    ctkDICOMFilterProxyModel* model = const_cast<ctkDICOMFilterProxyModel*>(qobject_cast<const ctkDICOMFilterProxyModel*>(index.model()));
+    ctkDICOMModel* model = const_cast<ctkDICOMModel*>(qobject_cast<const ctkDICOMModel*>(index.model()));
 
-    if(model){
+    if(model)
+    {
         model->fetchMore(patientIndex);
         int studyCount = model->rowCount(patientIndex);
 
-        for(int i=0; i<studyCount; i++){
+        for(int i=0; i<studyCount; i++)
+        {
             QModelIndex studyIndex = patientIndex.child(i, 0);
             QModelIndex seriesIndex = studyIndex.child(0, 0);
             model->fetchMore(seriesIndex);
             int imageCount = model->rowCount(seriesIndex);
             QModelIndex imageIndex = seriesIndex.child(imageCount/2, 0);
 
-            QString thumbnailPath = this->databaseDirectory +
+            QString thumbnailPath = this->DatabaseDirectory +
                                     "/thumbs/" + model->data(studyIndex ,ctkDICOMModel::UIDRole).toString() + "/" +
                                     model->data(seriesIndex ,ctkDICOMModel::UIDRole).toString() + "/" +
                                     model->data(imageIndex, ctkDICOMModel::UIDRole).toString() + ".png";
 
-            if(QFile(thumbnailPath).exists()){
+            if(QFile(thumbnailPath).exists())
+            {
                 this->addThumbnailWidget(imageIndex, studyIndex, model->data(studyIndex, Qt::DisplayRole).toString());
             }
         }
@@ -90,28 +109,29 @@ void ctkDICOMThumbnailListWidgetPrivate::onPatientModelSelected(const QModelInde
 }
 
 void ctkDICOMThumbnailListWidgetPrivate::onStudyModelSelected(const QModelIndex &index){
-    Q_Q(ctkDICOMThumbnailListWidget);
-
     QModelIndex studyIndex = index;
 
-    ctkDICOMFilterProxyModel* model = const_cast<ctkDICOMFilterProxyModel*>(qobject_cast<const ctkDICOMFilterProxyModel*>(index.model()));
+    ctkDICOMModel* model = const_cast<ctkDICOMModel*>(qobject_cast<const ctkDICOMModel*>(index.model()));
 
-    if(model){
+    if(model)
+    {
         model->fetchMore(studyIndex);
         int seriesCount = model->rowCount(studyIndex);
 
-        for(int i=0; i<seriesCount; i++){
+        for(int i=0; i<seriesCount; i++)
+        {
             QModelIndex seriesIndex = studyIndex.child(i, 0);
             model->fetchMore(seriesIndex);
             int imageCount = model->rowCount(seriesIndex);
             QModelIndex imageIndex = seriesIndex.child(imageCount/2, 0);
 
-            QString thumbnailPath = this->databaseDirectory +
+            QString thumbnailPath = this->DatabaseDirectory +
                                     "/thumbs/" + model->data(studyIndex ,ctkDICOMModel::UIDRole).toString() + "/" +
                                     model->data(seriesIndex ,ctkDICOMModel::UIDRole).toString() + "/" +
                                     model->data(imageIndex, ctkDICOMModel::UIDRole).toString() + ".png";
 
-            if (QFile(thumbnailPath).exists()){
+            if (QFile(thumbnailPath).exists())
+            {
                 this->addThumbnailWidget(imageIndex, seriesIndex, model->data(seriesIndex, Qt::DisplayRole).toString());
             }
         }
@@ -119,14 +139,13 @@ void ctkDICOMThumbnailListWidgetPrivate::onStudyModelSelected(const QModelIndex
 }
 
 void ctkDICOMThumbnailListWidgetPrivate::onSeriesModelSelected(const QModelIndex &index){
-    Q_Q(ctkDICOMThumbnailListWidget);
-
     QModelIndex studyIndex = index.parent();
     QModelIndex seriesIndex = index;
 
-    ctkDICOMFilterProxyModel* model = const_cast<ctkDICOMFilterProxyModel*>(qobject_cast<const ctkDICOMFilterProxyModel*>(index.model()));
+    ctkDICOMModel* model = const_cast<ctkDICOMModel*>(qobject_cast<const ctkDICOMModel*>(index.model()));
 
-    if(model){
+    if(model)
+    {
         model->fetchMore(seriesIndex);
 
         int imageCount = model->rowCount(seriesIndex);
@@ -135,12 +154,13 @@ void ctkDICOMThumbnailListWidgetPrivate::onSeriesModelSelected(const QModelIndex
         {
             QModelIndex imageIndex = seriesIndex.child(i,0);
 
-            QString thumbnailPath = this->databaseDirectory +
+            QString thumbnailPath = this->DatabaseDirectory +
                                     "/thumbs/" + model->data(studyIndex ,ctkDICOMModel::UIDRole).toString() + "/" +
                                     model->data(seriesIndex ,ctkDICOMModel::UIDRole).toString() + "/" +
                                     model->data(imageIndex, ctkDICOMModel::UIDRole).toString() + ".png";
 
-            if(QFile(thumbnailPath).exists()){
+            if(QFile(thumbnailPath).exists())
+            {
                 this->addThumbnailWidget(imageIndex, imageIndex, QString("Image %1").arg(i));
             }
         }
@@ -152,9 +172,11 @@ void ctkDICOMThumbnailListWidgetPrivate::clearAllThumbnails(){
 
     // Remove previous displayed thumbnails
     QLayoutItem* item;
-    while(item = this->scrollAreaContentWidget->layout()->takeAt(0)){
+    while((item = this->ScrollAreaContentWidget->layout()->takeAt(0)))
+    {
         ctkDICOMThumbnailWidget* thumbnailWidget = qobject_cast<ctkDICOMThumbnailWidget*>(item->widget());
-        if(thumbnailWidget){
+        if(thumbnailWidget)
+        {
             q->disconnect(thumbnailWidget, SIGNAL(selected(ctkDICOMThumbnailWidget)), q, SLOT(onThumbnailSelected(ctkDICOMThumbnailWidget)));
             q->disconnect(thumbnailWidget, SIGNAL(selected(ctkDICOMThumbnailWidget)), q, SIGNAL(selected(ctkDICOMThumbnailWidget)));
             q->disconnect(thumbnailWidget, SIGNAL(doubleClicked(ctkDICOMThumbnailWidget)), q, SIGNAL(doubleClicked(ctkDICOMThumbnailWidget)));
@@ -166,25 +188,26 @@ void ctkDICOMThumbnailListWidgetPrivate::clearAllThumbnails(){
 void ctkDICOMThumbnailListWidgetPrivate::addThumbnailWidget(const QModelIndex& imageIndex, const QModelIndex& sourceIndex, const QString &text){
     Q_Q(ctkDICOMThumbnailListWidget);
 
-    ctkDICOMFilterProxyModel* model = const_cast<ctkDICOMFilterProxyModel*>(qobject_cast<const ctkDICOMFilterProxyModel*>(imageIndex.model()));
+    ctkDICOMModel* model = const_cast<ctkDICOMModel*>(qobject_cast<const ctkDICOMModel*>(imageIndex.model()));
 
-    if(model){
+    if(model)
+    {
         QModelIndex seriesIndex = imageIndex.parent();
         QModelIndex studyIndex = seriesIndex.parent();
 
-        QString thumbnailPath = this->databaseDirectory +
+        QString thumbnailPath = this->DatabaseDirectory +
                                 "/thumbs/" + model->data(studyIndex ,ctkDICOMModel::UIDRole).toString() + "/" +
                                 model->data(seriesIndex ,ctkDICOMModel::UIDRole).toString() + "/" +
                                 model->data(imageIndex, ctkDICOMModel::UIDRole).toString() + ".png";
 
-        ctkDICOMThumbnailWidget* widget = new ctkDICOMThumbnailWidget(this->scrollAreaContentWidget);
+        ctkDICOMThumbnailWidget* widget = new ctkDICOMThumbnailWidget(this->ScrollAreaContentWidget);
         QString widgetLabel = text;
         widget->setText( widgetLabel );
         QPixmap pix(thumbnailPath);
         logger.debug("Setting pixmap to " + thumbnailPath);
         widget->setPixmap(pix);
         widget->setSourceIndex(sourceIndex);
-        this->scrollAreaContentWidget->layout()->addWidget(widget);
+        this->ScrollAreaContentWidget->layout()->addWidget(widget);
         q->connect(widget, SIGNAL(selected(ctkDICOMThumbnailWidget)), q, SLOT(onThumbnailSelected(ctkDICOMThumbnailWidget)));
         q->connect(widget, SIGNAL(selected(ctkDICOMThumbnailWidget)), q, SIGNAL(selected(ctkDICOMThumbnailWidget)));
         q->connect(widget, SIGNAL(doubleClicked(ctkDICOMThumbnailWidget)), q, SIGNAL(doubleClicked(ctkDICOMThumbnailWidget)));
@@ -202,7 +225,7 @@ ctkDICOMThumbnailListWidget::ctkDICOMThumbnailListWidget(QWidget* _parent):Super
 
     d->setupUi(this);
 
-    d->scrollAreaContentWidget->setLayout(new ctkFlowLayout);
+    d->ScrollAreaContentWidget->setLayout(new ctkFlowLayout);
 }
 
 //----------------------------------------------------------------------------
@@ -217,25 +240,29 @@ ctkDICOMThumbnailListWidget::~ctkDICOMThumbnailListWidget()
 void ctkDICOMThumbnailListWidget::setDatabaseDirectory(const QString &directory){
     Q_D(ctkDICOMThumbnailListWidget);
 
-    d->databaseDirectory = directory;
+    d->DatabaseDirectory = directory;
 }
 
 //----------------------------------------------------------------------------
 void ctkDICOMThumbnailListWidget::selectThumbnail(int index){
     Q_D(ctkDICOMThumbnailListWidget);
 
-    int count = d->scrollAreaContentWidget->layout()->count();
+    int count = d->ScrollAreaContentWidget->layout()->count();
 
     logger.debug("Select thumbnail " + QVariant(index).toString() + " of " + QVariant(count).toString());
 
     if(index >= count)return;
 
-    for(int i=0; i<count; i++){
-        ctkDICOMThumbnailWidget* thumbnailWidget = qobject_cast<ctkDICOMThumbnailWidget*>(d->scrollAreaContentWidget->layout()->itemAt(i)->widget());
-        if(i == index){
+    for(int i=0; i<count; i++)
+    {
+        ctkDICOMThumbnailWidget* thumbnailWidget = qobject_cast<ctkDICOMThumbnailWidget*>(d->ScrollAreaContentWidget->layout()->itemAt(i)->widget());
+        if(i == index)
+        {
             thumbnailWidget->setSelected(true);
-            d->scrollArea->ensureWidgetVisible(thumbnailWidget);
-        }else{
+            d->ScrollArea->ensureWidgetVisible(thumbnailWidget);
+        }
+        else
+        {
             thumbnailWidget->setSelected(false);
         }
     }
@@ -245,20 +272,24 @@ void ctkDICOMThumbnailListWidget::selectThumbnail(int index){
 void ctkDICOMThumbnailListWidget::selectThumbnail(const QModelIndex &index){
     Q_D(ctkDICOMThumbnailListWidget);
 
-    if(!d->currentSelectedModel.isValid())return;
-    if(index.parent() != d->currentSelectedModel)return;
+    if(!d->CurrentSelectedModel.isValid())return;
+    if(index.parent() != d->CurrentSelectedModel)return;
 
-    ctkDICOMFilterProxyModel* model = const_cast<ctkDICOMFilterProxyModel*>(qobject_cast<const ctkDICOMFilterProxyModel*>(index.model()));
+    ctkDICOMModel* model = const_cast<ctkDICOMModel*>(qobject_cast<const ctkDICOMModel*>(index.model()));
 
-    if(model){
-        int count = d->scrollAreaContentWidget->layout()->count();
+    if(model)
+    {
+        int count = d->ScrollAreaContentWidget->layout()->count();
 
-        for(int i=0; i<count; i++){
-            ctkDICOMThumbnailWidget* thumbnailWidget = qobject_cast<ctkDICOMThumbnailWidget*>(d->scrollAreaContentWidget->layout()->itemAt(i)->widget());
+        for(int i=0; i<count; i++)
+        {
+            ctkDICOMThumbnailWidget* thumbnailWidget = qobject_cast<ctkDICOMThumbnailWidget*>(d->ScrollAreaContentWidget->layout()->itemAt(i)->widget());
             if(thumbnailWidget->sourceIndex() == index){
                 thumbnailWidget->setSelected(true);
-                d->scrollArea->ensureWidgetVisible(thumbnailWidget);
-            }else{
+                d->ScrollArea->ensureWidgetVisible(thumbnailWidget);
+            }
+            else
+            {
                 thumbnailWidget->setSelected(false);
             }
         }
@@ -271,18 +302,24 @@ void ctkDICOMThumbnailListWidget::onModelSelected(const QModelIndex &index){
 
     d->clearAllThumbnails();
 
-    ctkDICOMFilterProxyModel* model = const_cast<ctkDICOMFilterProxyModel*>(qobject_cast<const ctkDICOMFilterProxyModel*>(index.model()));
+    ctkDICOMModel* model = const_cast<ctkDICOMModel*>(qobject_cast<const ctkDICOMModel*>(index.model()));
 
-    if(model){
+    if(model)
+    {
         QModelIndex index0 = index.sibling(index.row(), 0);
 
-        d->currentSelectedModel = index0;
+        d->CurrentSelectedModel = index0;
 
-        if ( model->data(index0,ctkDICOMModel::TypeRole) == ctkDICOMModel::PatientType ){
+        if ( model->data(index0,ctkDICOMModel::TypeRole) == static_cast<int>(ctkDICOMModel::PatientType) )
+        {
             d->onPatientModelSelected(index0);
-        }else if ( model->data(index0,ctkDICOMModel::TypeRole) == ctkDICOMModel::StudyType ){
+        }
+        else if ( model->data(index0,ctkDICOMModel::TypeRole) == static_cast<int>(ctkDICOMModel::StudyType) )
+        {
             d->onStudyModelSelected(index0);
-        }else if ( model->data(index0,ctkDICOMModel::TypeRole) == ctkDICOMModel::SeriesType ){
+        }
+        else if ( model->data(index0,ctkDICOMModel::TypeRole) == static_cast<int>(ctkDICOMModel::SeriesType) )
+        {
             d->onSeriesModelSelected(index0);
         }
     }
@@ -293,11 +330,12 @@ void ctkDICOMThumbnailListWidget::onModelSelected(const QModelIndex &index){
 //----------------------------------------------------------------------------
 void ctkDICOMThumbnailListWidget::onThumbnailSelected(const ctkDICOMThumbnailWidget &widget){
     Q_D(ctkDICOMThumbnailListWidget);
-    for(int i=0; i<d->scrollAreaContentWidget->layout()->count(); i++){
-        ctkDICOMThumbnailWidget* thumbnailWidget = qobject_cast<ctkDICOMThumbnailWidget*>(d->scrollAreaContentWidget->layout()->itemAt(i)->widget());
-        if(thumbnailWidget && (&widget != thumbnailWidget)){
+    for(int i=0; i<d->ScrollAreaContentWidget->layout()->count(); i++)
+    {
+        ctkDICOMThumbnailWidget* thumbnailWidget = qobject_cast<ctkDICOMThumbnailWidget*>(d->ScrollAreaContentWidget->layout()->itemAt(i)->widget());
+        if(thumbnailWidget && (&widget != thumbnailWidget))
+        {
             thumbnailWidget->setSelected(false);
         }
     }
 }
-

+ 19 - 16
Libs/DICOM/Widgets/ctkDICOMThumbnailWidget.cpp

@@ -42,11 +42,11 @@ public:
     // Constructor
     ctkDICOMThumbnailWidgetPrivate(ctkDICOMThumbnailWidget* parent);
 
-    bool selectedFlag;
+    bool SelectedFlag;
 
-    QColor backgroundColor;
+    QColor BackgroundColor;
 
-    QModelIndex sourceIndex;
+    QModelIndex SourceIndex;
 };
 
 //----------------------------------------------------------------------------
@@ -55,8 +55,8 @@ public:
 ctkDICOMThumbnailWidgetPrivate::ctkDICOMThumbnailWidgetPrivate(ctkDICOMThumbnailWidget* parent): q_ptr(parent){
     Q_Q(ctkDICOMThumbnailWidget);
 
-    this->selectedFlag = false;
-    this->backgroundColor = q->palette().color(QPalette::Highlight);
+    this->SelectedFlag = false;
+    this->BackgroundColor = q->palette().color(QPalette::Highlight);
 }
 
 //----------------------------------------------------------------------------
@@ -82,14 +82,14 @@ void ctkDICOMThumbnailWidget::setText(const QString &text)
 {
   Q_D(ctkDICOMThumbnailWidget);
 
-  d->textLabel->setText(text);
+  d->TextLabel->setText(text);
 }
 
 //----------------------------------------------------------------------------
 QString ctkDICOMThumbnailWidget::text()const
 {
   Q_D(const ctkDICOMThumbnailWidget);
-  return d->textLabel->text();
+  return d->TextLabel->text();
 }
 
 //----------------------------------------------------------------------------
@@ -97,7 +97,7 @@ void ctkDICOMThumbnailWidget::setPixmap(const QPixmap &pixmap)
 {
   Q_D(ctkDICOMThumbnailWidget);
 
-  d->pixmapLabel->setPixmap(pixmap);
+  d->PixmapLabel->setPixmap(pixmap);
 }
 
 //----------------------------------------------------------------------------
@@ -105,43 +105,46 @@ const QPixmap* ctkDICOMThumbnailWidget::pixmap()const
 {
   Q_D(const ctkDICOMThumbnailWidget);
 
-  return d->pixmapLabel->pixmap();
+  return d->PixmapLabel->pixmap();
 }
 
 //----------------------------------------------------------------------------
 void ctkDICOMThumbnailWidget::setSourceIndex(QModelIndex index){
     Q_D(ctkDICOMThumbnailWidget);
 
-    d->sourceIndex = index;
+    d->SourceIndex = index;
 }
 
 //----------------------------------------------------------------------------
 QModelIndex ctkDICOMThumbnailWidget::sourceIndex() const{
     Q_D(const ctkDICOMThumbnailWidget);
 
-    return d->sourceIndex;
+    return d->SourceIndex;
 }
 
 //----------------------------------------------------------------------------
 void ctkDICOMThumbnailWidget::setSelected(bool flag){
     Q_D(ctkDICOMThumbnailWidget);
 
-    if(flag){
+    if(flag)
+    {
         QPalette p(this->palette());
-        p.setColor(QPalette::Window, d->backgroundColor);
+        p.setColor(QPalette::Window, d->BackgroundColor);
         this->setPalette(p);
         this->setAutoFillBackground(true);
-    }else{
+    }
+    else
+    {
         this->setAutoFillBackground(false);
     }
 
-    d->selectedFlag = flag;
+    d->SelectedFlag = flag;
 }
 
 //----------------------------------------------------------------------------
 bool ctkDICOMThumbnailWidget::isSelected(){
     Q_D(ctkDICOMThumbnailWidget);
-    return d->selectedFlag;
+    return d->SelectedFlag;
 }
 
 //----------------------------------------------------------------------------