Explorar o código

Replaced for loop with iterators.

Andreas Fetzer %!s(int64=10) %!d(string=hai) anos
pai
achega
8f543ee99f
Modificáronse 1 ficheiros con 7 adicións e 4 borrados
  1. 7 4
      Libs/XNAT/Core/ctkXnatObject.cpp

+ 7 - 4
Libs/XNAT/Core/ctkXnatObject.cpp

@@ -229,15 +229,18 @@ void ctkXnatObject::add(ctkXnatObject* child)
   }
 
   bool childExists (false);
-  foreach (ctkXnatObject* existingChild, d->children)
+
+  QList<ctkXnatObject*>::iterator iter;
+  for (iter = d->children.begin(); iter != d->children.end(); ++iter)
   {
-    if ((existingChild->id().length() != 0 && existingChild->id() == child->id()) ||
-        (existingChild->id().length() == 0 && existingChild->name() == child->name()))
+    if (((*iter)->id().length() != 0 && (*iter)->id() == child->id()) ||
+        ((*iter)->id().length() == 0 && (*iter)->name() == child->name()))
     {
-      d->children.replace(d->children.indexOf(existingChild), child);
+      *iter = child;
       childExists = true;
     }
   }
+
   if (!childExists)
   {
     d->children.push_back(child);