Преглед изворни кода

Simplify ctkDICOMTableView constructor removing redundant call

This commit removes the gratuitous call to "lblTableName->setText()".
Following commit 3831125 (Refactoring and code clean up), the call
to "setQueryTableName()" fulfills the same role.

This commit also ensure the call to "setQueryTableName()" is consistently
done after initializing the pimpl.

Suggested-by: Sergey Aleshin <4memph@gmail.com>
Jean-Christophe Fillion-Robin пре 10 година
родитељ
комит
b9d32d2573
1 измењених фајлова са 1 додато и 2 уклоњено
  1. 1 2
      Libs/DICOM/Widgets/ctkDICOMTableView.cpp

+ 1 - 2
Libs/DICOM/Widgets/ctkDICOMTableView.cpp

@@ -198,7 +198,6 @@ ctkDICOMTableView::ctkDICOMTableView(QString queryTableName, QWidget *parent)
   Q_D(ctkDICOMTableView);
   d->init();
   this->setQueryTableName(queryTableName);
-  d->lblTableName->setText(queryTableName);
 }
 
 //------------------------------------------------------------------------------
@@ -208,8 +207,8 @@ ctkDICOMTableView::ctkDICOMTableView (ctkDICOMDatabase* dicomDataBase, QString q
 {
   this->setDicomDataBase(dicomDataBase);
   Q_D(ctkDICOMTableView);
-  this->setQueryTableName(queryTableName);
   d->init();
+  this->setQueryTableName(queryTableName);
 }
 
 //------------------------------------------------------------------------------