소스 검색

Avoid saving to disk and generating thumbnails for in memory database

Specify correct values for default arguments as suggested by Dragan Toroman


"You should also correct the calls to database.insert() to reflect the needed use.
For instance, in ctkDICOMQuery, the call to database.insert() is missing "false, false"
(causing some side-efects, like trying to generate thumbnails for non-existent images)"

See:
https://github.com/commontk/CTK/issues/16
Steve Pieper 14 년 전
부모
커밋
e768b49f47
1개의 변경된 파일2개의 추가작업 그리고 2개의 파일을 삭제
  1. 2 2
      Libs/DICOM/Core/ctkDICOMQuery.cpp

+ 2 - 2
Libs/DICOM/Core/ctkDICOMQuery.cpp

@@ -362,7 +362,7 @@ bool ctkDICOMQuery::query(ctkDICOMDatabase& database )
     DcmDataset *dataset = (*it)->m_dataset;
     if ( dataset != NULL )
       {
-      database.insert ( dataset );
+      database.insert ( dataset, false, false );
       OFString StudyInstanceUID;
       dataset->findAndGetOFString ( DCM_StudyInstanceUID, StudyInstanceUID );
       d->addStudyInstanceUID ( QString ( StudyInstanceUID.c_str() ) );
@@ -390,7 +390,7 @@ bool ctkDICOMQuery::query(ctkDICOMDatabase& database )
         DcmDataset *dataset = (*it)->m_dataset;
         if ( dataset != NULL )
           {
-          database.insert ( dataset );
+          database.insert ( dataset, false, false );
           }
         }
       logger.debug ( "Find succeded for Series: " + StudyInstanceUID );