ctkSettingsPanelTest.cpp 21 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421
  1. /*=========================================================================
  2. Library: CTK
  3. Copyright (c) Kitware Inc.
  4. Licensed under the Apache License, Version 2.0 (the "License");
  5. you may not use this file except in compliance with the License.
  6. You may obtain a copy of the License at
  7. http://www.apache.org/licenses/LICENSE-2.0.txt
  8. Unless required by applicable law or agreed to in writing, software
  9. distributed under the License is distributed on an "AS IS" BASIS,
  10. WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  11. See the License for the specific language governing permissions and
  12. limitations under the License.
  13. =========================================================================*/
  14. // Qt includes
  15. #include <QApplication>
  16. #include <QSettings>
  17. #include <QSignalSpy>
  18. #include <QSpinBox>
  19. // CTK includes
  20. #include "ctkSettingsPanel.h"
  21. #include "ctkSettingsPanelTest2Helper.h"
  22. #include "ctkTest.h"
  23. // STD includes
  24. #include <cstdlib>
  25. #include <iostream>
  26. // ----------------------------------------------------------------------------
  27. class ctkSettingsPanelTester: public QObject
  28. {
  29. Q_OBJECT
  30. private slots:
  31. void testChangeProperty();
  32. void testChangeProperty_data();
  33. void testEmptyQStringList();
  34. void testResetRestoreReloadSettings();
  35. void testResetRestoreReloadSettings_data();
  36. };
  37. //-----------------------------------------------------------------------------
  38. void ctkSettingsPanelTester::testChangeProperty()
  39. {
  40. QFETCH(bool, registerSpecificSettings);
  41. QSettings settings(QSettings::IniFormat, QSettings::UserScope, "Common ToolKit", "CTK");
  42. QSettings specificSettings(QSettings::IniFormat, QSettings::UserScope, "Common ToolKit", "CTK-specific");
  43. // Clear settings
  44. settings.clear();
  45. settings.sync();
  46. specificSettings.clear();
  47. specificSettings.sync();
  48. QSpinBox spinBox;
  49. ctkSettingsPanel panel;
  50. panel.setSettings(&settings);
  51. spinBox.setValue(1);
  52. QFETCH(QString, label);
  53. QFETCH(ctkSettingsPanel::SettingOptions, options);
  54. panel.registerProperty("property", &spinBox,
  55. "value", SIGNAL(valueChanged(int)),
  56. label, options, registerSpecificSettings ? &specificSettings : 0);
  57. QCOMPARE(spinBox.value(), 1);
  58. QCOMPARE(panel.settingLabel("property"), label);
  59. QCOMPARE(panel.settingOptions("property"), options);
  60. qRegisterMetaType<QVariant>("QVariant");
  61. QSignalSpy spy(&panel, SIGNAL(settingChanged(QString,QVariant)));
  62. QFETCH(int, value);
  63. QFETCH(bool, setOnObject);
  64. if (setOnObject)
  65. {
  66. spinBox.setValue(value);
  67. }
  68. else
  69. {
  70. panel.setSetting("property", QVariant(value));
  71. }
  72. QFETCH(int, expectedSettingChangedCount);
  73. QCOMPARE(spy.count(), expectedSettingChangedCount);
  74. QFETCH(QStringList, expectedChangedSettings);
  75. QCOMPARE(panel.changedSettings(), expectedChangedSettings);
  76. // make sure it didn't change
  77. QCOMPARE(panel.settingLabel("property"), label);
  78. QCOMPARE(panel.settingOptions("property"), options);
  79. QString currentSettingContent;
  80. {
  81. settings.sync();
  82. if (QFile::exists(settings.fileName()))
  83. {
  84. QFile file(settings.fileName());
  85. QVERIFY(file.open(QIODevice::ReadOnly));
  86. currentSettingContent = file.readAll();
  87. file.close();
  88. }
  89. }
  90. QString currentSpecificSettingsContent;
  91. {
  92. specificSettings.sync();
  93. if (QFile::exists(specificSettings.fileName()))
  94. {
  95. QFile file(specificSettings.fileName());
  96. QVERIFY(file.open(QIODevice::ReadOnly));
  97. currentSpecificSettingsContent = file.readAll();
  98. file.close();
  99. }
  100. }
  101. QString expectedSettingsContent = QLatin1String("[General]\nproperty=%1\n");
  102. if (expectedChangedSettings.count() > 0)
  103. {
  104. if (registerSpecificSettings)
  105. {
  106. QCOMPARE(currentSettingContent, QString(""));
  107. QCOMPARE(currentSpecificSettingsContent, expectedSettingsContent.arg(value));
  108. }
  109. else
  110. {
  111. QCOMPARE(currentSettingContent, expectedSettingsContent.arg(value));
  112. QCOMPARE(currentSpecificSettingsContent, QString(""));
  113. }
  114. }
  115. else
  116. {
  117. if (registerSpecificSettings)
  118. {
  119. QCOMPARE(currentSettingContent, QString(""));
  120. QCOMPARE(currentSpecificSettingsContent, expectedSettingsContent.arg(1));
  121. }
  122. else
  123. {
  124. QCOMPARE(currentSettingContent, expectedSettingsContent.arg(1));
  125. QCOMPARE(currentSpecificSettingsContent, QString(""));
  126. }
  127. }
  128. panel.resetSettings();
  129. }
  130. //-----------------------------------------------------------------------------
  131. void ctkSettingsPanelTester::testChangeProperty_data()
  132. {
  133. QTest::addColumn<QString>("label");
  134. QTest::addColumn<ctkSettingsPanel::SettingOptions>("options");
  135. QTest::addColumn<int>("value");
  136. QTest::addColumn<bool>("setOnObject");
  137. QTest::addColumn<bool>("registerSpecificSettings");
  138. QTest::addColumn<int>("expectedSettingChangedCount");
  139. QTest::addColumn<QStringList>("expectedChangedSettings");
  140. // registerSpecificSettings: false
  141. QTest::newRow("null none changed obj") << QString() << ctkSettingsPanel::SettingOptions(ctkSettingsPanel::OptionNone) << 2 << true << false << 1 << QStringList("property");
  142. QTest::newRow("null none changed panel") << QString() << ctkSettingsPanel::SettingOptions(ctkSettingsPanel::OptionNone) << 2 << false << false << 1 << QStringList("property");
  143. QTest::newRow("null none unchanged obj") << QString() << ctkSettingsPanel::SettingOptions(ctkSettingsPanel::OptionNone) << 1 << true << false << 0 << QStringList();
  144. QTest::newRow("null none unchanged panel") << QString() << ctkSettingsPanel::SettingOptions(ctkSettingsPanel::OptionNone) << 1 << false << false << 0 << QStringList();
  145. QTest::newRow("null RequireRestart changed obj") << QString() << ctkSettingsPanel::SettingOptions(ctkSettingsPanel::OptionRequireRestart) << 2 << true << false << 1 << QStringList("property");
  146. QTest::newRow("null RequireRestart changed panel") << QString() << ctkSettingsPanel::SettingOptions(ctkSettingsPanel::OptionRequireRestart) << 2 << false << false << 1 << QStringList("property");
  147. QTest::newRow("null RequireRestart unchanged obj") << QString() << ctkSettingsPanel::SettingOptions(ctkSettingsPanel::OptionRequireRestart) << 1 << true << false << 0 << QStringList();
  148. QTest::newRow("null RequireRestart unchanged panel") << QString() << ctkSettingsPanel::SettingOptions(ctkSettingsPanel::OptionRequireRestart) << 1 << false << false << 0 << QStringList();
  149. QTest::newRow("empty none changed obj") << QString("") << ctkSettingsPanel::SettingOptions(ctkSettingsPanel::OptionNone) << 2 << true << false << 1 << QStringList("property");
  150. QTest::newRow("empty none changed panel") << QString("") << ctkSettingsPanel::SettingOptions(ctkSettingsPanel::OptionNone) << 2 << false << false << 1 << QStringList("property");
  151. QTest::newRow("empty none unchanged obj") << QString("") << ctkSettingsPanel::SettingOptions(ctkSettingsPanel::OptionNone) << 1 << true << false << 0 << QStringList();
  152. QTest::newRow("empty none unchanged panel") << QString("") << ctkSettingsPanel::SettingOptions(ctkSettingsPanel::OptionNone) << 1 << false << false << 0 << QStringList();
  153. QTest::newRow("empty RequireRestart changed obj") << QString("") << ctkSettingsPanel::SettingOptions(ctkSettingsPanel::OptionRequireRestart) << 2 << true << false << 1 << QStringList("property");
  154. QTest::newRow("empty RequireRestart changed panel") << QString("") << ctkSettingsPanel::SettingOptions(ctkSettingsPanel::OptionRequireRestart) << 2 << false << false << 1 << QStringList("property");
  155. QTest::newRow("empty RequireRestart unchanged obj") << QString("") << ctkSettingsPanel::SettingOptions(ctkSettingsPanel::OptionRequireRestart) << 1 << true << false << 0 << QStringList();
  156. QTest::newRow("empty RequireRestart unchanged panel") << QString("") << ctkSettingsPanel::SettingOptions(ctkSettingsPanel::OptionRequireRestart) << 1 << false << false << 0 << QStringList();
  157. QTest::newRow("label none changed obj") << QString("label") << ctkSettingsPanel::SettingOptions(ctkSettingsPanel::OptionNone) << 2 << true << false << 1 << QStringList("property");
  158. QTest::newRow("label none changed panel") << QString("label") << ctkSettingsPanel::SettingOptions(ctkSettingsPanel::OptionNone) << 2 << false << false << 1 << QStringList("property");
  159. QTest::newRow("label none unchanged obj") << QString("label") << ctkSettingsPanel::SettingOptions(ctkSettingsPanel::OptionNone) << 1 << true << false << 0 << QStringList();
  160. QTest::newRow("label none unchanged panel") << QString("label") << ctkSettingsPanel::SettingOptions(ctkSettingsPanel::OptionNone) << 1 << false << false << 0 << QStringList();
  161. QTest::newRow("label RequireRestart changed obj") << QString("label") << ctkSettingsPanel::SettingOptions(ctkSettingsPanel::OptionRequireRestart) << 2 << true << false << 1 << QStringList("property");
  162. QTest::newRow("label RequireRestart changed panel") << QString("label") << ctkSettingsPanel::SettingOptions(ctkSettingsPanel::OptionRequireRestart) << 2 << false << false << 1 << QStringList("property");
  163. QTest::newRow("label RequireRestart unchanged obj") << QString("label") << ctkSettingsPanel::SettingOptions(ctkSettingsPanel::OptionRequireRestart) << 1 << true << false << 0 << QStringList();
  164. QTest::newRow("label RequireRestart unchanged panel") << QString("label") << ctkSettingsPanel::SettingOptions(ctkSettingsPanel::OptionRequireRestart) << 1 << false << false << 0 << QStringList();
  165. // registerSpecificSettings: true
  166. QTest::newRow("null none changed obj") << QString() << ctkSettingsPanel::SettingOptions(ctkSettingsPanel::OptionNone) << 2 << true << true << 1 << QStringList("property");
  167. QTest::newRow("null none changed panel") << QString() << ctkSettingsPanel::SettingOptions(ctkSettingsPanel::OptionNone) << 2 << false << true << 1 << QStringList("property");
  168. QTest::newRow("null none unchanged obj") << QString() << ctkSettingsPanel::SettingOptions(ctkSettingsPanel::OptionNone) << 1 << true << true << 0 << QStringList();
  169. QTest::newRow("null none unchanged panel") << QString() << ctkSettingsPanel::SettingOptions(ctkSettingsPanel::OptionNone) << 1 << false << true << 0 << QStringList();
  170. QTest::newRow("null RequireRestart changed obj") << QString() << ctkSettingsPanel::SettingOptions(ctkSettingsPanel::OptionRequireRestart) << 2 << true << true << 1 << QStringList("property");
  171. QTest::newRow("null RequireRestart changed panel") << QString() << ctkSettingsPanel::SettingOptions(ctkSettingsPanel::OptionRequireRestart) << 2 << false << true << 1 << QStringList("property");
  172. QTest::newRow("null RequireRestart unchanged obj") << QString() << ctkSettingsPanel::SettingOptions(ctkSettingsPanel::OptionRequireRestart) << 1 << true << true << 0 << QStringList();
  173. QTest::newRow("null RequireRestart unchanged panel") << QString() << ctkSettingsPanel::SettingOptions(ctkSettingsPanel::OptionRequireRestart) << 1 << false << true << 0 << QStringList();
  174. QTest::newRow("empty none changed obj") << QString("") << ctkSettingsPanel::SettingOptions(ctkSettingsPanel::OptionNone) << 2 << true << true << 1 << QStringList("property");
  175. QTest::newRow("empty none changed panel") << QString("") << ctkSettingsPanel::SettingOptions(ctkSettingsPanel::OptionNone) << 2 << false << true << 1 << QStringList("property");
  176. QTest::newRow("empty none unchanged obj") << QString("") << ctkSettingsPanel::SettingOptions(ctkSettingsPanel::OptionNone) << 1 << true << true << 0 << QStringList();
  177. QTest::newRow("empty none unchanged panel") << QString("") << ctkSettingsPanel::SettingOptions(ctkSettingsPanel::OptionNone) << 1 << false << true << 0 << QStringList();
  178. QTest::newRow("empty RequireRestart changed obj") << QString("") << ctkSettingsPanel::SettingOptions(ctkSettingsPanel::OptionRequireRestart) << 2 << true << true << 1 << QStringList("property");
  179. QTest::newRow("empty RequireRestart changed panel") << QString("") << ctkSettingsPanel::SettingOptions(ctkSettingsPanel::OptionRequireRestart) << 2 << false << true << 1 << QStringList("property");
  180. QTest::newRow("empty RequireRestart unchanged obj") << QString("") << ctkSettingsPanel::SettingOptions(ctkSettingsPanel::OptionRequireRestart) << 1 << true << true << 0 << QStringList();
  181. QTest::newRow("empty RequireRestart unchanged panel") << QString("") << ctkSettingsPanel::SettingOptions(ctkSettingsPanel::OptionRequireRestart) << 1 << false << true << 0 << QStringList();
  182. QTest::newRow("label none changed obj") << QString("label") << ctkSettingsPanel::SettingOptions(ctkSettingsPanel::OptionNone) << 2 << true << true << 1 << QStringList("property");
  183. QTest::newRow("label none changed panel") << QString("label") << ctkSettingsPanel::SettingOptions(ctkSettingsPanel::OptionNone) << 2 << false << true << 1 << QStringList("property");
  184. QTest::newRow("label none unchanged obj") << QString("label") << ctkSettingsPanel::SettingOptions(ctkSettingsPanel::OptionNone) << 1 << true << true << 0 << QStringList();
  185. QTest::newRow("label none unchanged panel") << QString("label") << ctkSettingsPanel::SettingOptions(ctkSettingsPanel::OptionNone) << 1 << false << true << 0 << QStringList();
  186. QTest::newRow("label RequireRestart changed obj") << QString("label") << ctkSettingsPanel::SettingOptions(ctkSettingsPanel::OptionRequireRestart) << 2 << true << true << 1 << QStringList("property");
  187. QTest::newRow("label RequireRestart changed panel") << QString("label") << ctkSettingsPanel::SettingOptions(ctkSettingsPanel::OptionRequireRestart) << 2 << false << true << 1 << QStringList("property");
  188. QTest::newRow("label RequireRestart unchanged obj") << QString("label") << ctkSettingsPanel::SettingOptions(ctkSettingsPanel::OptionRequireRestart) << 1 << true << true << 0 << QStringList();
  189. QTest::newRow("label RequireRestart unchanged panel") << QString("label") << ctkSettingsPanel::SettingOptions(ctkSettingsPanel::OptionRequireRestart) << 1 << false << true << 0 << QStringList();
  190. }
  191. namespace
  192. {
  193. //-----------------------------------------------------------------------------
  194. class ctkSettingsPanelForTest : public ctkSettingsPanel
  195. {
  196. public:
  197. QVariant myDefaultPropertyValue(const QString& key) const
  198. {
  199. return this->defaultPropertyValue(key);
  200. }
  201. QVariant myPreviousPropertyValue(const QString& key) const
  202. {
  203. return this->previousPropertyValue(key);
  204. }
  205. QVariant myPropertyValue(const QString& key) const
  206. {
  207. return this->propertyValue(key);
  208. }
  209. };
  210. } // end of anonymous namespace
  211. //-----------------------------------------------------------------------------
  212. void ctkSettingsPanelTester::testEmptyQStringList()
  213. {
  214. {
  215. // When QSettings goes out of scope, we are the settings file is up-to-date
  216. QSettings settings(QSettings::IniFormat, QSettings::UserScope, "Common ToolKit", "CTK");
  217. settings.clear();
  218. settings.setValue("list", QVariant(QStringList()));
  219. }
  220. // Regression: Reading empty QStringList property from settings should be handled properly
  221. // See issue #646
  222. ctkSettingsPanelForTest settingsPanel;
  223. ctkSettingsPanelTest2Helper * list = new ctkSettingsPanelTest2Helper(&settingsPanel);
  224. settingsPanel.registerProperty("list", list, "list", SIGNAL(listChanged()));
  225. QSettings settings2(QSettings::IniFormat, QSettings::UserScope, "Common ToolKit", "CTK");
  226. settingsPanel.setSettings(&settings2);
  227. QVariant listVal = settings2.value("list");
  228. QCOMPARE(listVal.isValid(), false); // See issue #646
  229. QCOMPARE(listVal, QVariant()); // See issue #646
  230. QCOMPARE(listVal.toStringList(), QStringList());
  231. QCOMPARE(settingsPanel.myPreviousPropertyValue("list").toStringList(), QStringList());
  232. QCOMPARE(settingsPanel.myDefaultPropertyValue("list").toStringList(), QStringList());
  233. QCOMPARE(settingsPanel.myPropertyValue("list").toStringList(), QStringList());
  234. }
  235. //-----------------------------------------------------------------------------
  236. void ctkSettingsPanelTester::testResetRestoreReloadSettings()
  237. {
  238. QSettings settings(QSettings::IniFormat, QSettings::UserScope, "Common ToolKit", "CTK");
  239. // Clear settings
  240. settings.clear();
  241. settings.sync();
  242. int settingsValue = 1;
  243. int initValue = 2;
  244. int newValue = 3;
  245. QFETCH(bool, setSettingsValue);
  246. if (setSettingsValue)
  247. {
  248. settings.setValue("key 1", settingsValue);
  249. }
  250. QSpinBox spinBox;
  251. spinBox.setValue(initValue);
  252. ctkSettingsPanel settingsPanel;
  253. settingsPanel.setSettings(&settings);
  254. settingsPanel.registerProperty("key 1", &spinBox, "value",
  255. SIGNAL(valueChanged(int)));
  256. QFETCH(bool, setSpinBoxValue);
  257. if (setSpinBoxValue)
  258. {
  259. spinBox.setValue(newValue);
  260. }
  261. QFETCH(bool, applySettings);
  262. if (applySettings)
  263. {
  264. settingsPanel.applySettings();
  265. }
  266. QFETCH(bool, resetSettings);
  267. if (resetSettings)
  268. {
  269. settingsPanel.resetSettings();
  270. }
  271. QFETCH(bool, restoreDefaultSettings);
  272. if (restoreDefaultSettings)
  273. {
  274. settingsPanel.restoreDefaultSettings();
  275. }
  276. QFETCH(bool, reloadSettings);
  277. if (reloadSettings)
  278. {
  279. settingsPanel.reloadSettings();
  280. }
  281. QFETCH(int, finalValue);
  282. QCOMPARE(settings.value("key 1").toInt(), finalValue);
  283. }
  284. //-----------------------------------------------------------------------------
  285. void ctkSettingsPanelTester::testResetRestoreReloadSettings_data()
  286. {
  287. QTest::addColumn<bool>("setSettingsValue");
  288. QTest::addColumn<bool>("setSpinBoxValue");
  289. QTest::addColumn<bool>("applySettings");
  290. QTest::addColumn<bool>("resetSettings");
  291. QTest::addColumn<bool>("restoreDefaultSettings");
  292. QTest::addColumn<bool>("reloadSettings");
  293. QTest::addColumn<int>("finalValue");
  294. int settingsValue = 1;
  295. int initValue = 2;
  296. int newValue = 3;
  297. // settings spinbox apply reset restore reload final
  298. QTest::newRow("set value")
  299. << false << true << false << false << false << false << newValue;
  300. QTest::newRow("reload")
  301. << false << true << false << false << false << true << newValue;
  302. QTest::newRow("restore")
  303. << false << true << false << false << true << false << initValue;
  304. QTest::newRow("restore and reload")
  305. << false << true << false << false << true << true << initValue;
  306. QTest::newRow("reset")
  307. << false << true << false << true << false << false << initValue;
  308. QTest::newRow("reset and reload")
  309. << false << true << false << true << false << true << initValue;
  310. QTest::newRow("reset and restore")
  311. << false << true << false << true << true << false << initValue;
  312. QTest::newRow("reset, restore and reload")
  313. << false << true << false << true << true << true << initValue;
  314. QTest::newRow("apply")
  315. << false << true << true << false << false << false << newValue;
  316. QTest::newRow("apply and reload")
  317. << false << true << true << false << false << true << newValue;
  318. QTest::newRow("apply and restore")
  319. << false << true << true << false << true << false << initValue;
  320. QTest::newRow("apply, restore and reload")
  321. << false << true << true << false << true << true << initValue;
  322. QTest::newRow("apply and reset")
  323. << false << true << true << true << false << false << newValue;
  324. QTest::newRow("apply, reset and reload")
  325. << false << true << true << true << false << true << newValue;
  326. QTest::newRow("apply, reset and restore")
  327. << false << true << true << true << true << false << initValue;
  328. QTest::newRow("apply, reset, restore and reload")
  329. << false << true << true << true << true << true << initValue;
  330. // with existing settings
  331. // settings spinbox apply reset restore reload final
  332. QTest::newRow("set value with settings")
  333. << true << true << false << false << false << false << newValue;
  334. QTest::newRow("reload with settings")
  335. << true << true << false << false << false << true << newValue;
  336. QTest::newRow("restore with settings")
  337. << true << true << false << false << true << false << initValue;
  338. QTest::newRow("restore and reload with settings")
  339. << true << true << false << false << true << true << initValue;
  340. QTest::newRow("reset with settings")
  341. << true << true << false << true << false << false << settingsValue;
  342. QTest::newRow("reset and reload with settings")
  343. << true << true << false << true << false << true << settingsValue;
  344. QTest::newRow("reset and restore with settings")
  345. << true << true << false << true << true << false << initValue;
  346. QTest::newRow("reset, restore and reload with settings")
  347. << true << true << false << true << true << true << initValue;
  348. QTest::newRow("apply with settings")
  349. << true << true << true << false << false << false << newValue;
  350. QTest::newRow("apply and reload with settings")
  351. << true << true << true << false << false << true << newValue;
  352. QTest::newRow("apply and restore with settings")
  353. << true << true << true << false << true << false << initValue;
  354. QTest::newRow("apply, restore and reload with settings")
  355. << true << true << true << false << true << true << initValue;
  356. QTest::newRow("apply and reset with settings")
  357. << true << true << true << true << false << false << newValue;
  358. QTest::newRow("apply, reset and reload with settings")
  359. << true << true << true << true << false << true << newValue;
  360. QTest::newRow("apply, reset and restore with settings")
  361. << true << true << true << true << true << false << initValue;
  362. QTest::newRow("apply, reset, restore and reload with settings")
  363. << true << true << true << true << true << true << initValue;
  364. }
  365. // ----------------------------------------------------------------------------
  366. CTK_TEST_MAIN(ctkSettingsPanelTest)
  367. #include "moc_ctkSettingsPanelTest.cpp"